Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page
From:   Qian Cai <cai@lca.pw>
In-Reply-To: <20200115082947.GA21018@infradead.org>
Date:   Wed, 15 Jan 2020 13:27:57 -0500
Cc:     Alex Shi <alex.shi@linux.alibaba.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F5F5B735-2BEA-4B9D-8939-B24B9D9AA940@lca.pw>
References: <1579006500-127143-1-git-send-email-alex.shi@linux.alibaba.com>
 <FC618797-2F5E-4F73-A244-0DC19AA1CB74@lca.pw>
 <20200115082947.GA21018@infradead.org>
To:     Christoph Hellwig <hch@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jan 15, 2020, at 3:29 AM, Christoph Hellwig <hch@infradead.org> =
wrote:
>=20
> On Tue, Jan 14, 2020 at 08:46:21AM -0500, Qian Cai wrote:
>>=20
>>=20
>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@linux.alibaba.com> =
wrote:
>>>=20
>>> This macro are never used in git history. So better to remove.
>>=20
>> When removing unused thingy, it is important to figure out which =
commit introduced it in the first place and Cc the relevant people in =
that commit.
>=20
> No, it isn't.  It is at best nice to have, but for a trivial macro
> really doesn't matter.

A more of personal taste what the trivial macro is. I=E2=80=99d rather =
be on the caution side
when removing code especially nowaday developers may not even compile
test the patch properly given how many arches we have here which will =
only waste
time on other people when things goes wrong.=