Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Andy Lutomirski <luto@amacapital.net>
Mime-Version: 1.0 (1.0)
Subject: Re: Fix built-in early-load Intel microcode alignment
Date:   Wed, 15 Jan 2020 11:00:29 -0800
Message-Id: <5C216684-6FDF-41B5-9F51-89DC295F6DDC@amacapital.net>
References: <CACMCwJLJCA2iXS0QMKKAWQv252oUcmfsNvwDNP5+4Z_9VB-rTg@mail.gmail.com>
Cc:     Luis Chamberlain <mcgrof@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        johannes.berg@intel.com, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
        Andy Lutomirski <luto@kernel.org>
In-Reply-To: <CACMCwJLJCA2iXS0QMKKAWQv252oUcmfsNvwDNP5+4Z_9VB-rTg@mail.gmail.com>
To:     Jari Ruusu <jari.ruusu@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jan 15, 2020, at 10:46 AM, Jari Ruusu <jari.ruusu@gmail.com> wrote:
>=20
> =EF=BB=BFOn 1/15/20, Luis Chamberlain <mcgrof@kernel.org> wrote:
>>> On Mon, Jan 13, 2020 at 09:58:25PM +0200, Jari Ruusu wrote:
>>> Before that 16-byte alignment patch was applied, my only one
>>> microcode built-in BLOB was "accidentally" 16-byte aligned.
>>=20
>> How did it accidentially get 16-byte aligned?
>=20
> Old code aligned it to 8-bytes.
> There is 50/50-chance of it also being 16-byte aligned.
> So it ended up being both 8-byte and 16-byte aligned.
>=20
>> Also, how do you *know* something is broken right now?
>=20
> I haven't spotted brokenness in Linux microcode loader other
> than that small alignment issue.
>=20
> However, I can confirm that there are 2 microcode updates newer
> than what my laptop computer's latest BIOS includes. Both newer
> ones (20191115 and 20191112) are unstable on my laptop computer
> i5-7200U (fam 6 model 142 step 9 pf 0x80). Hard lockups with both
> of them. Back to BIOS microcode for now.
>=20

Hard lockup when loaded or hard lockup after loading?

> --=20
> Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F1=
89