Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] SGE buffer and max_inline data must have same size
From:   Rao Shoaib <rao.shoaib@oracle.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     linux-rdma@vger.kernel.org, monis@mellanox.com,
        dledford@redhat.com, sean.hefty@intel.com,
        hal.rosenstock@gmail.com, linux-kernel@vger.kernel.org
References: <1578962480-17814-1-git-send-email-rao.shoaib@oracle.com>
 <1578962480-17814-3-git-send-email-rao.shoaib@oracle.com>
 <20200115182721.GE25201@ziepe.ca>
 <93b8e890-c4a9-6050-88b7-3667c023dd34@oracle.com>
Message-ID: <70651c3f-e5cb-2a33-1682-6564255e2307@oracle.com>
Date:   Wed, 15 Jan 2020 12:05:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <93b8e890-c4a9-6050-88b7-3667c023dd34@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/15/20 11:57 AM, Rao Shoaib wrote:
>
>> I seem to recall the if the requested max can't be satisified then
>> that is an EINVAL?
>>
>> And the init->cap should be updated with the actual allocation.
>
> Since the user request for both (sge's and inline data) has been 
> satisfied I decided not to update the values in case the return values 
> are being checked. If you prefer that I update the values I can do that.
>
> Shoaib
>
In my original v1 patch I did update init->cap, I must have overlooked 
it. I will resubmit the patch with that change once I hear back from you 
about the enforcement.

Shoaib