Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <0000000000007523a60576e80a47@google.com> <CACT4Y+b3AmVQMjPNsPHOXRZS4tNYb6Z9h5-c=1ZwZk0VR-5J5Q@mail.gmail.com>
 <20180928070042.GF3439@hirez.programming.kicks-ass.net> <CACT4Y+YFmSmXjs5EMNRPvsR-mLYeAYKypBppYq_M_boTi8a9uQ@mail.gmail.com>
 <CACT4Y+ZBYYUiJejNbPcZWS+aHehvkgKkTKm0gvuviXGGcirJ5g@mail.gmail.com> <CACT4Y+bTGp1J9Wn=93LUObdTcWPo2JrChYKF-1v6aXmtvoQgPQ@mail.gmail.com>
In-Reply-To: <CACT4Y+bTGp1J9Wn=93LUObdTcWPo2JrChYKF-1v6aXmtvoQgPQ@mail.gmail.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Wed, 15 Jan 2020 13:53:28 -0800
Message-ID: <CAM_iQpVtcNFeEtW15z_nZoyC1Q-_pCq+UfZ4vYBB3Lb2CMm4Mg@mail.gmail.com>
Subject: Re: BUG: MAX_LOCKDEP_CHAINS too low!
To:     Dmitry Vyukov <dvyukov@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Taehee Yoo <ap420073@gmail.com>,
        syzbot <syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com>,
        Ingo Molnar <mingo@kernel.org>,
        Will Deacon <will.deacon@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 13, 2020 at 3:11 AM Dmitry Vyukov <dvyukov@google.com> wrote:
> +Taehee, Cong,
>
> In the other thread Taehee mentioned the creation of dynamic keys for
> net devices that was added recently and that they are subject to some
> limits.
> syzkaller creates lots of net devices for isolation (several dozens
> per test process, but then these can be created and destroyed
> periodically). I wonder if it's the root cause of the lockdep limits
> problems?

Very possibly. In current code base, there are 4 lockdep keys
per netdev:

        struct lock_class_key   qdisc_tx_busylock_key;
        struct lock_class_key   qdisc_running_key;
        struct lock_class_key   qdisc_xmit_lock_key;
        struct lock_class_key   addr_list_lock_key;

so the number of lockdep keys is at least 4x number of network
devices.

I think only addr_list_lock_key is necessary as it has a nested
locking use case, all the rest are not. Taehee, do you agree?

I plan to remove at least qdisc_xmit_lock_key for net-next
after the fix for net gets merged.

Thanks!