Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: M3m7FjSuxvr2lfdNM3u0L2ePD+w8ovjL5fp4yXIBgg0jcq8+WzvlHOh2wOgZwMLyHvUzr+2SNy
 W9YJ8SHDCARjSIPnLkhy8EdkUz/dovTukELXOOyLFKZ+/8TnN4sTEAT55TVQA/Eg5KHt2swDDr
 7GqcMd3h0cNtYWKzs9CBdDow94j5/dFjTVwq/Usvo/bzcYBXFFMZryrstMUp4Qsve+PVZJaPEM
 BcW+aVZ/Wo+knjbphgF3Gyd3Ixh1kbR82nFRGtJsfGRhut8r7MIJsDSG+56Q4ONuTUc7o/8/k7
 5Z4=
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chao Yu <yuchao0@huawei.com>
CC:     Yuehaibing <yuehaibing@huawei.com>,
        "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "chao@kernel.org" <chao@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable
 'cs_block'
Thread-Topic: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable
 'cs_block'
Thread-Index: AQHVulgQExCdjuBytUKA1yv69qLf+qfLyO2AgAAnP4CAACbggIAfDJoAgAB7MYCAAPN8gA==
Date:   Thu, 16 Jan 2020 00:25:52 +0000
Message-ID: <20200116002551.oq7hxzyiazppalsb@shindev.dhcp.fujisawa.hgst.com>
References: <20191224124359.15040-1-yuehaibing@huawei.com>
 <673efe18-d528-2e9b-6d44-a6a7a22086f3@huawei.com>
 <62ce1981-9061-f798-a65d-9599ceceb4b8@huawei.com>
 <20191226082419.ljbhystwkhp2d4gh@shindev.dhcp.fujisawa.hgst.com>
 <20200115023328.bummaaa7pdnao5qk@shindev.dhcp.fujisawa.hgst.com>
 <0aea7754-2114-cc78-3453-bc608bacd45a@huawei.com>
In-Reply-To: <0aea7754-2114-cc78-3453-bc608bacd45a@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F7ABFD392685E8468F3FB9E7BA2D6DC1@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f5a5b47c-b690-4546-df4c-08d79a1aa4f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2020 00:25:52.1027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ria/9qiXo+nlujZ2L2i/2C+1RxvbPEAEQHtmbvKA5kRqRi0x+6/Sc/2bwuB4ejqNCgmO77hDtFi0OJjwffz5/s/ucG5sUIp5QPrGci/6glQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR04MB2169
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jan 15, 2020 / 17:54, Chao Yu wrote:
> On 2020/1/15 10:33, Shinichiro Kawasaki wrote:
> > On Dec 26, 2019 / 17:24, Shin'ichiro Kawasaki wrote:
> >> On Dec 26, 2019 / 14:05, Yuehaibing wrote:
> >>> On 2019/12/26 11:44, Chao Yu wrote:
> >>>> On 2019/12/24 20:43, YueHaibing wrote:
> >>>>> fs/f2fs/segment.c: In function fix_curseg_write_pointer:
> >>>>> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not u=
sed [-Wunused-but-set-variable]
> >>>>>
> >>>>> It is never used since commit 362d8a920384 ("f2fs: Check
> >>>>> write pointer consistency of open zones") , so remove it.
> >>>>
> >>>> Thanks for the fix!
> >>>>
> >>>> Do you mind merging this patch to original patch? as it's still
> >>>> pending in dev branch.
> >>>
> >>> It's ok for me.
> >>>
> >>
> >> Thank you for this catch and the fix. Appreciated.
> >=20
> > I have merged YueHaibing's change to the write pointer consistency fix =
patch
> > and sent out as the v6 series. Thanks again for finding out the unused =
variable.
> >=20
> > I was not sure if I should add Chao Yu's reviewed by tag to the patch f=
rom which
> > the unused variable was removed. To be strict, I didn't add the tag. Ju=
st
> > another quick review by Chao will be appreciated.
>=20
> Thanks for the revision. :)
>=20
> I guess Jaegeuk can merge that kind of fix into original patch, and
> meanwhile keeping old Reviewed-by tag in that patch.

Yeah, my action looks too much for this fix. I saw the fix merged to the co=
mmit
in Jaegeuk's dev branch. Thank you Jaeguek.

--
Best Regards,
Shin'ichiro Kawasaki=