Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Subject: Re: [PATCH RFC 1/3] x86/kvm/hyper-v: remove stale
 evmcs_already_enabled check from nested_enable_evmcs()
From:   Liran Alon <liran.alon@oracle.com>
In-Reply-To: <20200115171014.56405-2-vkuznets@redhat.com>
Date:   Thu, 16 Jan 2020 00:50:39 +0200
Cc:     kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Jim Mattson <jmattson@google.com>,
        linux-kernel@vger.kernel.org, Roman Kagan <rkagan@virtuozzo.com>
Content-Transfer-Encoding: 7bit
Message-Id: <7CBE44B7-E554-480D-9280-E29247C70178@oracle.com>
References: <20200115171014.56405-1-vkuznets@redhat.com>
 <20200115171014.56405-2-vkuznets@redhat.com>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 15 Jan 2020, at 19:10, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> 
> In nested_enable_evmcs() evmcs_already_enabled check doesn't really do
> anything: controls are already sanitized and we return '0' regardless.
> Just drop the check.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Reviewed-by: Liran Alon <liran.alon@oracle.com>

-Liran

> ---
> arch/x86/kvm/vmx/evmcs.c | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx/evmcs.c b/arch/x86/kvm/vmx/evmcs.c
> index 72359709cdc1..89c3e0caf39f 100644
> --- a/arch/x86/kvm/vmx/evmcs.c
> +++ b/arch/x86/kvm/vmx/evmcs.c
> @@ -350,17 +350,12 @@ int nested_enable_evmcs(struct kvm_vcpu *vcpu,
> 			uint16_t *vmcs_version)
> {
> 	struct vcpu_vmx *vmx = to_vmx(vcpu);
> -	bool evmcs_already_enabled = vmx->nested.enlightened_vmcs_enabled;
> 
> 	vmx->nested.enlightened_vmcs_enabled = true;
> 
> 	if (vmcs_version)
> 		*vmcs_version = nested_get_evmcs_version(vcpu);
> 
> -	/* We don't support disabling the feature for simplicity. */
> -	if (evmcs_already_enabled)
> -		return 0;
> -
> 	vmx->nested.msrs.pinbased_ctls_high &= ~EVMCS1_UNSUPPORTED_PINCTRL;
> 	vmx->nested.msrs.entry_ctls_high &= ~EVMCS1_UNSUPPORTED_VMENTRY_CTRL;
> 	vmx->nested.msrs.exit_ctls_high &= ~EVMCS1_UNSUPPORTED_VMEXIT_CTRL;
> -- 
> 2.24.1
>