Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7265781ybl; Wed, 15 Jan 2020 19:06:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxV5gHcZV33mA4Zxz/5WnVKSuMPEaunT5IGx47ffAMvRJbf7r+5lo2HSAnXtnYNqRBL3mxj X-Received: by 2002:a05:6808:181:: with SMTP id w1mr2655707oic.176.1579143995523; Wed, 15 Jan 2020 19:06:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579143995; cv=none; d=google.com; s=arc-20160816; b=qVYXcZI2w+rpkT2jbzj8l/4aH4GHgbRPNR5SmLtoynBVcU5rXrTmwLn+VbQC96AHXZ LqqEw9pqNyWy7wNNemmkENXJUlzNBm55XbOh+7Nwl3MFM8zBPA6FtSXrbHls/mAIxaui iMS7Vq6Vi01O3KDuDMRy7vPe+OcqZqvyiMAgllV5e256nDeF2DbNBPBX5L7XRuGUY3bg hYMzcGWFyLEz9+HNPSKsHPLXNJ1b517B+JB2p3iqYv/ZEXVfGSUNfoMnjYe2H98smkEY QAZEVobbYoQIy/2uDOY60Eq9u+3D46xYVh7W9aRIGIjAv9L6z6zfR5dLrGJLKBpqQhwq z1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=zn3ijF2UKcUHwQmffWHQLCtnjm0JlhF9MWcMTiP7i/4=; b=t0cKO0eKpLssq+F8RXr6LQ3O2agkSCxn8NjFXENRfeP1hGAMEVfU9ZTPISY1B4dGGc kFJ/SJ+nIEONPuP7RH5757x7kfuP4WjgEmrre5L+AsLcZDerPlekV1ET1jd03IOLHHGT 8a4uZxSqRSsoUYdzP20vWmqy63PHLQlRTWlYufZUyfhWkQePLxWCx3NNkIPBKurhRBl+ xb5qFXWFITOhStG24eLTXl1TOqtfPdbdDvEcdplApiyrJT6Irh9rS8fY3TYmBO2hA/L9 NPTQOupsYq/zvBdCXtQhNaXIu8sHo1QYFZCbnw/JGkiunFDSN4uRgVvKo08nUVPPwrt/ y1yA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si11985112otn.150.2020.01.15.19.06.23; Wed, 15 Jan 2020 19:06:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730632AbgAPCED convert rfc822-to-8bit (ORCPT + 99 others); Wed, 15 Jan 2020 21:04:03 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2560 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729431AbgAPCED (ORCPT ); Wed, 15 Jan 2020 21:04:03 -0500 Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id D19F737F32F697526E1E; Thu, 16 Jan 2020 10:04:01 +0800 (CST) Received: from dggeme764-chm.china.huawei.com (10.3.19.110) by DGGEMM405-HUB.china.huawei.com (10.3.20.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 10:04:01 +0800 Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by dggeme764-chm.china.huawei.com (10.3.19.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 16 Jan 2020 10:04:01 +0800 Received: from dggeme763-chm.china.huawei.com ([10.6.66.36]) by dggeme763-chm.china.huawei.com ([10.6.66.36]) with mapi id 15.01.1713.004; Thu, 16 Jan 2020 10:03:59 +0800 From: linmiaohe To: Marc Zyngier CC: "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "james.morse@arm.com" , "julien.thierry.kdev@gmail.com" , "suzuki.poulose@arm.com" , "christoffer.dall@arm.com" , "catalin.marinas@arm.com" , "eric.auger@redhat.com" , "gregkh@linuxfoundation.org" , "will@kernel.org" , "andre.przywara@arm.com" , "tglx@linutronix.de" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" Subject: Re: [PATCH] KVM: arm64: get rid of var ret and out jump label in kvm_arch_vcpu_ioctl_set_guest_debug() Thread-Topic: [PATCH] KVM: arm64: get rid of var ret and out jump label in kvm_arch_vcpu_ioctl_set_guest_debug() Thread-Index: AdXMEOY3ibkFZKiqSOySikptaJRgWA== Date: Thu, 16 Jan 2020 02:03:59 +0000 Message-ID: <36f01951fb09465e9981b870c536eea5@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marc Zyngier wrote: > > I don't think there is anything wrong with the existing code. > It may not be to your own taste, but is in keeping with a lot of the KVM code. > > If you were making changes to this code, I wouldn't object. > But on its own, this is just churn. > > Thanks, > > M. Oh, I see. Many thanks for your reply and patient explaination.