Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 Jan 2020 01:17:08 -0800 (PST)
Message-Id: <20200116.011708.119845983010961103.davem@davemloft.net>
To:     blackgod016574@gmail.com
Cc:     tglx@linutronix.de, alexios.zavras@intel.com, allison@lohutok.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: nfc: Removing unnecessaey code in
 nci_open_device()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200116025204.GA20032@hunterzg-yangtiant6900c-00>
References: <20200116025204.GA20032@hunterzg-yangtiant6900c-00>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Gen Zhang <blackgod016574@gmail.com>
Date: Thu, 16 Jan 2020 10:52:04 +0800

> In nci_open_device(), since we already call clear_bit(), so set ndev->flags
> to 0 is not needed.
> 
> Signed-off-by: Gen Zhang <blackgod016574@gmail.com>

There are several bits in this flags value, not just the one managed
here in this function (NCI_INIT).

This assignment is harmless and makes the code easier to audit,
therefore I am not applying this patch.