Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7600705ybl; Thu, 16 Jan 2020 02:24:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzufDVkAK/A+oIMzRT9f/1nzBFuoUW7l7/NjRfrS3hb++TdqcEPrePhqbH753fc7aWk5kT5 X-Received: by 2002:aca:398b:: with SMTP id g133mr3423692oia.11.1579170286896; Thu, 16 Jan 2020 02:24:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579170286; cv=none; d=google.com; s=arc-20160816; b=drQUZgBKPCH7SX8oe/0+CyPl31MPZXDuLXSu0nLxz72C60pVL+Z32Upt5hq8ClQgKJ mlbUM2xLKeJR+TxmzKbdgE5K/olvHAGagggkFFntC6/jVx9Df3EHlAnfuYLVZyLpfOJh stVT3rPR5lkH9tm4NdjFkjKaIwo6w7+zP8e/W3vJn3XIc/VHhRvB+PmIcWIBX6NbpxAx LkRePKezjimLPjpXldqk5gijfj0AvaFUVduLdW0AyYyx7sX5Ws1+hGmVHbZi7D/444Tr /VKCggx7GudkHsLZD5KOQK57aHcH+ZmOQdJFIYAQV6LeIWKdwESJ8/ExIkBhtKQiAgvk TULw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=47U5tmvt3CFIiOe6kVeEbf0TM4YD/kPpj8nUXNwd5zM=; b=koUj+22H8GlQt3HpQceSlik1+5GWqeHwJfzKaJGKfRIsfV4x/tWMtvDGTyfRSli7zi G8Elmje2vthyRnapSdXpKrdEVVsOXfazCNTR2aPdM4XCIfK3QBKHMQ2PuOFKuoBMqmg7 LgDmmHOpZs+dCDODDTvsC5yRG+scCFvovNEW+qh9ouQGRTBKYj2V7SBcOd1L2zU2xOxV XlhsXzrn9FAVe8JNFF6ATc+vbktyMETr6jq8N0HwqCWXdP1f+S+QSzP2Dad1VLwGLM+z XWs+raF0Y98qHixnmOI15y0+r7lD/3YIwjXsFamFeb29giyWpmLmFV174U3wcqt1XgPk 0USQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g14si12379791otj.10.2020.01.16.02.24.34; Thu, 16 Jan 2020 02:24:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730040AbgAPKH7 (ORCPT + 99 others); Thu, 16 Jan 2020 05:07:59 -0500 Received: from verein.lst.de ([213.95.11.211]:55148 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbgAPKH6 (ORCPT ); Thu, 16 Jan 2020 05:07:58 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id B6DD468BE1; Thu, 16 Jan 2020 11:07:54 +0100 (CET) Date: Thu, 16 Jan 2020 11:07:54 +0100 From: Christoph Hellwig To: Ralph Campbell Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-kselftest@vger.kernel.org, Jerome Glisse , John Hubbard , Christoph Hellwig , Jason Gunthorpe , Andrew Morton , Ben Skeggs , Shuah Khan Subject: Re: [PATCH v6 1/6] mm/mmu_notifier: add mmu_interval_notifier_insert_safe() Message-ID: <20200116100754.GA16347@lst.de> References: <20200113224703.5917-1-rcampbell@nvidia.com> <20200113224703.5917-2-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113224703.5917-2-rcampbell@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The name is weird, normally we call functions like this _locked. Additionally it will need a lockdep_assert_held to ensure the caller actually holds the lock.