Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7601125ybl; Thu, 16 Jan 2020 02:25:16 -0800 (PST) X-Google-Smtp-Source: APXvYqzoADnvuKqalSOoRkDtfXuwlNEW4Axv2FjC+Q6e8I9OlCslYutda5jU3PIkMFBUnNWp/s6J X-Received: by 2002:a9d:7f16:: with SMTP id j22mr1369671otq.256.1579170316652; Thu, 16 Jan 2020 02:25:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579170316; cv=none; d=google.com; s=arc-20160816; b=0E9GFHDESISp/VvaFnjgfVFTnyBo6RSs3SSjuUyVYezpy2kxzfxJwxUgafoMOn3AaF ef/HmDUeQtmrLmDsGf8a7yBett6ZfgL/8qx5zsRbHDOi5Hpzqwa3ZH6rTHP/wobcrnjO FZoOCbeytoKupqPnY6OQVToxWRK6m0b1vIpLJ4lK9nH5t/+GNuU/aARM35nlQd0agCAn AcLSpWFGGdwCYbMIQyw24S3e9l3FVDbpjJu6/Cw8MrqvnP007cWTcRhKhuudpR7ePjbN cr4xJuOG/6oCzJhAQHlSmAUGOHhS/ZUJdnyZfB45mLYZW8vmS4X/R0wO4eZjO2/xXR9F 6uQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JTzcAP+vBE8oB+WxJV4qULzL57Qr/ciVWcEXTq+vvdI=; b=bB53TABovHu49SjzIfgmXbUNwzL5qYR4uMA6oMsSP0QwHE2Z3pep1bvJJmjuylkkRn oowflrypN55S356gh4nOO3OYCXNR3arqYeD9R4ii9xjd22hv5cOk6eRYWBDU2PScUYE9 8O0BB20oc+johIWdxlIFUc2bTrWyQFxWkBcBbmtKEovunHbF1wVBEH6ptzdlTF9X0RPk WT5YZy6b1VVN17Y1TA9jOHiOao0A5FbQ+4w2Ba3ZfOVPvUVQFiDdvoTr3Je02WHkOL4z XG+UtRbHyP/juzGn13rbK2o8fMGy6xoB+VzVz1Iw94ZTAsDq/XkZe+NoOV+efWwfF9hX xrRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si10888124oib.115.2020.01.16.02.25.04; Thu, 16 Jan 2020 02:25:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731195AbgAPKOY (ORCPT + 99 others); Thu, 16 Jan 2020 05:14:24 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:33736 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726832AbgAPKOY (ORCPT ); Thu, 16 Jan 2020 05:14:24 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1is2AJ-00048J-GC; Thu, 16 Jan 2020 11:14:15 +0100 Date: Thu, 16 Jan 2020 11:14:15 +0100 From: Florian Westphal To: Dan Carpenter Cc: Pablo Neira Ayuso , coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , syzbot Subject: Re: [PATCH] netfilter: nf_tables: fix memory leak in nf_tables_parse_netdev_hooks() Message-ID: <20200116101415.GQ795@breakpoint.cc> References: <000000000000ffbba3059c3b5352@google.com> <20200116100931.ot2ef4jvsw4ldye2@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116100931.ot2ef4jvsw4ldye2@kili.mountain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter wrote: > Syzbot detected a leak in nf_tables_parse_netdev_hooks(). If the hook > already exists, then the error handling doesn't free the newest "hook". Thanks. Reviewed-by: Florian Westphal