Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7642770ybl; Thu, 16 Jan 2020 03:11:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwNF02hsjAFqXCC80HUARuXbfuybFjLhJxyBKkmzmy4NriSkb1KUkf4fWkdf/qOtqfar6o5 X-Received: by 2002:a9d:7b51:: with SMTP id f17mr1483442oto.302.1579173115637; Thu, 16 Jan 2020 03:11:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579173115; cv=none; d=google.com; s=arc-20160816; b=x1bkxdPLQJStZ+5tPLqCqwAwAwxWEPvBfpZSOA57e8BkJiTph8wuJ+TfAj6IggvBj3 p+yTIuFY7pZhYmAfq8cWFGA2uMKZrplBxQGNNa8U53bdxDjD/b0OtP46hxHxPGnZvQ/Y JxR1ob04PrlU3TVIRzO38nywD/UoC+X/+2qrTd/GV/MlmOfs4p/f+pA68XlDlMXTmqjY BkD9ZQ0SdmIobLgjZwLh0jEAv9+t6SKeZuFosU5elTTov1ZuklKHwJ+cEq8gFtNLBZU2 DwdJcbG7w7RrMUYKy4SLd4Z5jbsmtySKQHViOAJI/8Stzau/6H+yM2bv2XfTcvhE8bec MV9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=n1/dPpm22XLAc4Ter79t9sVIvIY/NefXaARN8Z7VU7w=; b=HIHtRqDDxm7ofk5u3cQZFR815CXkkaLAyqMcT/1oLxrYUNkpduxSO3ebPo12nTQwnU RgtQyLT/MZ+Ylj0hz9eNn9R1g+KwbrPAEFfEMji7S019tX/LCNO6giXdVk1Gd/m0nQ5M +M5kyN6e6CcObeJO5IEqFMOVRIWb4mgqhrL7nTWJKVZLRQxhLs/CutziekVyQZxQ+njW SBMpzrJ9H0t3ZUNTKLmVox/UZQ9uS53+eX1scuEbncwyliVTBDf+zkpqYOv+axTsMXKy 1m+pQ1QLiAbWafSYqMK8pJIqKqNzgavusAF20pzjCqWFz7mMrGopWngyRa/WciGdDvnL GLEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FDxpSI2I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38si3498987otu.166.2020.01.16.03.11.43; Thu, 16 Jan 2020 03:11:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FDxpSI2I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbgAPLJU (ORCPT + 99 others); Thu, 16 Jan 2020 06:09:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:43388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbgAPLJU (ORCPT ); Thu, 16 Jan 2020 06:09:20 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16F242072B; Thu, 16 Jan 2020 11:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579172959; bh=vc1eS1Q2QThKXCZG9OTh32DIlaGsAXxxnnsQoKtmYG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FDxpSI2IleBtE1CP1lydmOJTLtN7qR5EhtKAWBT4SkcqCQ2C003S4z7BH19ajI/AI m5y7zO0Nf4rerc+XhY4KkohEtm4qxtLBLSHZXBZV41BQjzBH3csEeLZabpO4Kwp+h2 qFuR9y7c0+3Q5scHUGWukt1ME/1H3mxhDZX4KR7I= Date: Thu, 16 Jan 2020 11:09:14 +0000 From: Will Deacon To: yeyunfeng Cc: catalin.marinas@arm.com, anshuman.khandual@arm.com, akpm@linux-foundation.org, willy@infradead.org, ard.biesheuvel@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hushiyuan@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH] arm64: mm: support setting page attributes for debug situation Message-ID: <20200116110914.GA16345@willie-the-truck> References: <5a3ab728-b895-0930-9540-5e9c586e8858@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a3ab728-b895-0930-9540-5e9c586e8858@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 03:47:41PM +0800, yeyunfeng wrote: > When rodata_full is set or pagealloc debug is enabled, block mappings or > contiguou hints are no longer used for linear address area. Therefore, > support setting page attributes in this case is useful for debugging > memory corruption problems. > > Signed-off-by: Yunfeng Ye > --- > arch/arm64/mm/pageattr.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) Although I can kind of see what you're getting at, I'm not keen on merging this without a user. If you're just referring to random debug hacks, then I think this change could be part of those too. Will