Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Qian Cai <cai@lca.pw>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page
Date:   Thu, 16 Jan 2020 07:26:23 -0500
Message-Id: <B6E75D9E-E9A2-4078-A89A-267310467B0A@lca.pw>
References: <739f4470-8dfe-bb2f-8100-2134f48868b6@linux.alibaba.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <739f4470-8dfe-bb2f-8100-2134f48868b6@linux.alibaba.com>
To:     Alex Shi <alex.shi@linux.alibaba.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jan 14, 2020, at 9:33 PM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
>=20
> =EF=BB=BF
>=20
>> =E5=9C=A8 2020/1/14 =E4=B8=8B=E5=8D=889:46, Qian Cai =E5=86=99=E9=81=93:
>>=20
>>=20
>>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@linux.alibaba.com> wrot=
e:
>>>=20
>>> This macro are never used in git history. So better to remove.
>>=20
>> When removing unused thingy, it is important to figure out which commit i=
ntroduced it in the first place and Cc the relevant people in that commit.
>>=20
>=20
> Thanks fore reminder, Qian!
>=20
> This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or c=
ommiter could be found.

Looks a bit deeper for this, and I am not sure if it is necessary to remove i=
t especially this does not cause any complication warning noise, because the=
 macro looks like a part of API design to have a pair of both read and write=
 version, even though only the write version is used at the moment.

In theory,  there could be users for the read version in the future, and the=
n it needs to be added back.=