Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     "Ardelean\, Alexandru" <alexandru.Ardelean@analog.com>,
        "m.olbrich\@pengutronix.de" <m.olbrich@pengutronix.de>
Cc:     "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bigeasy\@linutronix.de" <bigeasy@linutronix.de>,
        "lars\@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH] usb: dwc3: gadget: Handle dequeuing of non queued URB gracefully
In-Reply-To: <9d6ec804e3f1f462e5c6a43d19c83ff3493e3727.camel@analog.com>
References: <20191106144553.16956-1-alexandru.ardelean@analog.com> <20191112144108.GA1859@pengutronix.de> <9d6ec804e3f1f462e5c6a43d19c83ff3493e3727.camel@analog.com>
Date:   Thu, 16 Jan 2020 15:05:54 +0200
Message-ID: <87ftgf5z65.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> writes:
> On Tue, 2019-11-12 at 15:41 +0100, Michael Olbrich wrote:
>> [External]
>>=20
>> On Wed, Nov 06, 2019 at 04:45:53PM +0200, Alexandru Ardelean wrote:
>> > From: Lars-Peter Clausen <lars@metafoo.de>
>> >=20
>> > Trying to dequeue and URB that is currently not queued should be a no-
>> > op
>> > and be handled gracefully.
>> >=20
>> > Use the list field of the URB to indicate whether it is queued or not
>> > by
>> > setting it to the empty list when it is not queued.
>> >=20
>> > Handling this gracefully allows for race condition free synchronization
>> > between the complete callback being called to to a completed transfer
>> > and
>> > trying to call usb_ep_dequeue() at the same time.
>> >=20
>> > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>>=20
>> Thanks, no more "dwc3 fe200000.usb: request 00000000cdd42e4a was not
>> queued
>> to ep2in" messages with this patch applied.
>>=20
>> Tested-by: Michael Olbrich <m.olbrich@pengutronix.de>
>>=20
>
> I thought I replied here, but I guess I never hit the Send button.
> Many thanks @Michael for testing this.
>
> I'd also use the opportunity to make this a patch-ping message.

https://lore.kernel.org/linux-usb/875zhd6pw0.fsf@kernel.org/T/#u

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl4gX7IACgkQzL64meEa
mQbl/xAAxg29eDM+Ua+CWApxRhTmdYgTlYT5XRtQFBHBwhuRjqVtDLVx0dQsTM9d
+GAd0dJSWYIfYGKdNcs8F0QP+WGVd7iaW0XbtxoVQOyYA9fPyKrAuRZJ0cyB5oYP
dFBzXHtKihWnYhYDO/vpUxv0pq8f++3ulrPMyuL3ASgzo21aiGYhSYkw0A+K7lW5
xZhtOeEYTGtTtBm1KbT8Nf36e1Y7MNERLnswDIf/G/Mf9eZYvBChM7NldgWI0aBM
2eZlxWfd+G2pNWuEqmSs9pccLp/iqry4m1nh6sPj3CYVRTG1fYiBs8LK/DMhkW7N
SXaMzWfTnuyMaSpVDAKi8nS1IaZ+rbx8lqvUW58tlh19CIkljctu2MCGD87W2xEM
g2tXDEpJQl/EpDuHqBIB65JI73JiLHML70OUUxlaJkItM2IjpDd6qVRtIdQDQGIh
omebx8yY45K9ogM1ZmJTN87vm/ZNnSisdPZazOfWh6oD1ZnEGB5TNtRhN1ZFYMvt
56DntYRDF9vao7UoKeTIs8IiZjaQTtf9YByQLQ7e3J5x2IjcTEQFcpDZA92QpF/V
6iGNKJB3yInOAI5xHiEwHG5nOPUfnh/9ExqDRjzl83eooYyO9d0tb0NpdVE7mgFK
PN0t/WDQombAOaoVYun0PREpAlLSxKGlk0gY/nXASOofBuqXglM=
=hRcu
-----END PGP SIGNATURE-----
--=-=-=--