Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7771927ybl; Thu, 16 Jan 2020 05:26:17 -0800 (PST) X-Google-Smtp-Source: APXvYqxODXISIu9J6F3EG62SFPJjC/u9nChjFkqDCTkzwLi5qF9ykL6FVeWNjJUoRO+oVQ1wPn7v X-Received: by 2002:aca:fdd1:: with SMTP id b200mr3809557oii.133.1579181176992; Thu, 16 Jan 2020 05:26:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579181176; cv=none; d=google.com; s=arc-20160816; b=fPKcztHNzg7V6DvQ9Qy+7zdZ6ZVo6rKwFU1HShq+nmq7ki/mfEpBnAaNyH7Ny9fDR9 /BzCQ4/UjH7zxojPtA0yQReqStaYv62vkaWy6mLMjZ81numc09mTfCZwi/QK/fc3V5nm 7RaYhxx3UdMr90yFm+llAtZ/XSHdGo8iAv3lEaHyIku7Spbn1US+re2OC5tPsyJbaKaQ jdzUtHN28pJdYtJGiFYUUvcF0alKrO+/xwFUHjvy15abkS6oPBT9DFcvUwnvyZaePAMr 1RgZ++StdBBBJFY6+yQM15CQ9efm/C3wpzBIwD1JCuzRRCfX8PC0+CHHuJlgWda8znzE 7saQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v7jTUW5+K2kVIgC/NaO+mYPYmuJ/iTO8BIN9AU9m/uY=; b=Q8L1fzlZEKXguELjgFA3guuKyI27+OhlCyr1dRH6GhKnMk9fPuhbxZMlO1ekpVWtrE Tp40deHDNrxdcT76ntHaKEBKBMOif3qI8HcG4SV3p7edRNFWbk6Oodc/UI19BTJLs5bR ZFLBLc9yBJeYFasrWiC5JG6+lbPsPDmGVWI7fUff2YzwY4rXHv7NVmWq+g2PQZfSB1Pq KtCk1dOPiiAxDmTLfGUBDqvm/zYrG0/GY7xTWqST3+tPm3yO7BZUjx387OsjkKLAqnPv IXD3IN+bxpzBJucwuKIehKE/H39+kXhGaNoG2ZLJvszeopdT7g7EUZZxjuVjqUztkJOg vdmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rUTSUnWa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v141si11492431oif.161.2020.01.16.05.26.04; Thu, 16 Jan 2020 05:26:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rUTSUnWa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbgAPNYO (ORCPT + 99 others); Thu, 16 Jan 2020 08:24:14 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41728 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbgAPNYO (ORCPT ); Thu, 16 Jan 2020 08:24:14 -0500 Received: by mail-wr1-f68.google.com with SMTP id c9so19135435wrw.8 for ; Thu, 16 Jan 2020 05:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=v7jTUW5+K2kVIgC/NaO+mYPYmuJ/iTO8BIN9AU9m/uY=; b=rUTSUnWaH07o4mUO0LGTW9RL0tRTdeuWojYZwMsF6jAj3a/Avh0lYtdm3R8y5kQ/b2 MCg0DzT1mH7htZREPfDgGG/uuxpQhg9T1d+Y7QfjsYwwoWf6qEO4fYupt91WNFIsoAXI nxV8m7zqHDsJc/fREMsFCiL9FI6hKlKkMgPyIv6rFOd2TBE1HMa0sNBbFafmBJZK/zzP icYVguk1MmkWmMH36X/bpncwqB3qYHZwrW2X0NQdhUgoEZ7UBo1oSCW1OFM+tnW68uYO DyXQpH6EMjCPBp3WQWzd0GYxfa8QpyX+DfeuCWxGTLhv4DxLkwJTYP+OVk9GaNjcG2+u Oy+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=v7jTUW5+K2kVIgC/NaO+mYPYmuJ/iTO8BIN9AU9m/uY=; b=E3SXw2N3UlCrRMgJ82jaDX4sq1iZNoOEQgPWmQB7jTQphBwvjVIDPlhTSLPCcAkFyn ifOPzy3SFEm+iyK5cTIGe7FC3KLx5BwKPF0tbPlvSwoIp2DYcqqQcoJp8SIQMCVfncgg yE57K37XJ/dzJ1pnPuCdLQUVHHQKRL6VqCQg9dSj0KbBifMc2mX+pfPKKCX4jDNTQqmL 24U8C7Fz9IyWT+w7lhRKkgKGw0P5GYaL8c3AYvIzfdNiM+tsAA+C7K676i7AkMUwItWI D4Licew3yAcDGBcNGkP4iX5arQvV9L3lUO+MinC189/s6+31gX5lDN2cRmCbTmqP8/Ci z4Ug== X-Gm-Message-State: APjAAAV1dn4vcceMQN+74Vn6qA8++oXJ8MfgylQt5Vpxz/TvEhSEl+yx rtp4DkJ+OVhuiuKA03T1r2V0XWZI/bA= X-Received: by 2002:a5d:540f:: with SMTP id g15mr3241050wrv.86.1579181053002; Thu, 16 Jan 2020 05:24:13 -0800 (PST) Received: from dell ([2.27.35.221]) by smtp.gmail.com with ESMTPSA id c17sm29103415wrr.87.2020.01.16.05.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 05:24:12 -0800 (PST) Date: Thu, 16 Jan 2020 13:24:29 +0000 From: Lee Jones To: Charles Keepax Cc: linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2 3/3] mfd: madera: Allow more time for hardware reset Message-ID: <20200116132429.GL325@dell> References: <20200114151048.20282-1-ckeepax@opensource.cirrus.com> <20200114151048.20282-3-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200114151048.20282-3-ckeepax@opensource.cirrus.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jan 2020, Charles Keepax wrote: > Both manual and power on resets have a brief period where the chip will > not be accessible immediately afterwards. Extend the time allowed for > this from a minimum of 1mS to 2mS based on newer evaluation of the > hardware and ensure this reset happens in all reset conditions. Whilst > making the change also remove the redundant NULL checks in the reset > functions as the GPIO functions already check for this. > > Signed-off-by: Charles Keepax > --- > > Changes since v1: > - Switch from a helper function to defines for the delay > > This patch can be applied separately from the other patches in the series, > if needed. > > Thanks, > Charles > > drivers/mfd/madera-core.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog