Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 Jan 2020 14:56:50 +0100
From:   Jiri Pirko <jiri@resnulli.us>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Hongbo Yao <yaohongbo@huawei.com>, chenzhou10@huawei.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, mlxsw@mellanox.com
Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET
Message-ID: <20200116135412.GK2131@nanopsycho>
References: <20200116131404.169423-1-yaohongbo@huawei.com>
 <20200116053137.4b9f9ff9@cakuba.hsd1.ca.comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200116053137.4b9f9ff9@cakuba.hsd1.ca.comcast.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thu, Jan 16, 2020 at 02:31:37PM CET, kuba@kernel.org wrote:
>On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
>> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
>> Building drivers/net/netdevsim/fib.o will get the following error:
>> 
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
>> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
>> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>> 
>> Correct the Kconfig for netdevsim.
>> 
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
>
>Looks better :) Still missing a space between the hash and the bracket,
>but:
>
>Acked-by: Jakub Kicinski <kuba@kernel.org>
>
>While at it - does mlxsw have the same problem by any chance?

Looks like it does.