Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7806387ybl; Thu, 16 Jan 2020 06:00:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwDzUG82uezMVCkLT4xOY5sMy5OW8cAkJafsAu2Bu+A67W4Fdr+p0P5FQ0soEUE9oG4ELS7 X-Received: by 2002:aca:e106:: with SMTP id y6mr4139321oig.131.1579183255012; Thu, 16 Jan 2020 06:00:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579183255; cv=none; d=google.com; s=arc-20160816; b=BRxRRxzKKJOPJVS/2AbgLufmWCpbsWXO9mEMpV/RGzpd5TwLq8EV/xzTacP2JX1Ngt Wx/R8L9hscRrYw6APaR6SvRI4zOlW45b+aSuPs3h19RzVRvmLSuVwg+9Xzkp/5puC/Fs m5sat+IGvx17qYwSmeQk0qvMq57o9QcefmHLWJ7+nVA+A/P4PQy4OZCpKL+GUmn8fBQq WPca2DaIdVXkE8o0NIMNcGFvT570w5I2Nxpdecsusqyl68/ur5BkUQzHMBqcJN5jQWBZ cvSHCuaw+GjTqvlq41hlMI1f+VZg/zLVLvkcJ7i4jPQrAItn8ObdqbfF+iGnkvqv5fKc G1tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qXZMUQRvV5E0+EI46CYqoN4O4KKUmkIcqHfZtVdY97U=; b=OL/IbnXebfehSTyS35+S6VyjAdZixVQtTAOQC0m25Lcf81x2biuUjxEVhblj7ntM94 Bs6vJHaz4eHdo/MqulHXW5rLEaTEiz6SzNnbT3UuLBJEqVLyznHtKW/b9Hlv8l30h4ma T6ipmbIiUWSU+5osU4eL//7yk4RosGWkBNkv8zx/d6z9wvNHZPp9xSi758Q1FveJz9rJ l36wnNPG4jWHFYYH8g6pFgqTPWKStvrylrPv0iGBP1qum4aHme2Zus7hrjsygFgkd8bX 9/5BAVOeELGP7rZ3YnmaxfC2DAA9vPUFsWH9NKniH2jEWqVuul6GXvpWdNA94AGfgOeW P00A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x22si12256933otp.107.2020.01.16.06.00.42; Thu, 16 Jan 2020 06:00:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbgAPN7g (ORCPT + 99 others); Thu, 16 Jan 2020 08:59:36 -0500 Received: from correo.us.es ([193.147.175.20]:60964 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbgAPN7g (ORCPT ); Thu, 16 Jan 2020 08:59:36 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id EE8E52A2BBE for ; Thu, 16 Jan 2020 14:59:34 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id E0A97DA710 for ; Thu, 16 Jan 2020 14:59:34 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id CD07EDA70E; Thu, 16 Jan 2020 14:59:34 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C8B9EDA707; Thu, 16 Jan 2020 14:59:32 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 16 Jan 2020 14:59:32 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id A603342EF9E1; Thu, 16 Jan 2020 14:59:32 +0100 (CET) Date: Thu, 16 Jan 2020 14:59:32 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Dan Carpenter Cc: coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , syzbot Subject: Re: [PATCH] netfilter: nf_tables: fix memory leak in nf_tables_parse_netdev_hooks() Message-ID: <20200116135932.64pqshxvvvpoqawo@salvia> References: <000000000000ffbba3059c3b5352@google.com> <20200116100931.ot2ef4jvsw4ldye2@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116100931.ot2ef4jvsw4ldye2@kili.mountain> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 01:09:31PM +0300, Dan Carpenter wrote: > Syzbot detected a leak in nf_tables_parse_netdev_hooks(). If the hook > already exists, then the error handling doesn't free the newest "hook". Applied, thanks.