Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7984331ybl; Thu, 16 Jan 2020 08:46:08 -0800 (PST) X-Google-Smtp-Source: APXvYqws5qW/D6GovVm/7s53pE2wvJdxvGBGjo7QR637uSI6MPDDRN+JbEx6H/YQEjHRX57wLTOP X-Received: by 2002:a05:6830:1bf2:: with SMTP id k18mr2408713otb.78.1579193168161; Thu, 16 Jan 2020 08:46:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579193168; cv=none; d=google.com; s=arc-20160816; b=mAjKUk/1o12CAPF8cTfbLFZ/+NQrzpcsSOjrd0VWWahNRxNRsrmDMLHDEAwDHsJxyV qmyAPLFCMaFvbWGGqKYpPb4zEQ05aR4ZZ1pAN2jbfm32HKEhFII5Ch0PCGMlfSLZTd+h p0Zd/iAIAx8tf4qgSBf04PrrYZFjEd9CSkCjAF5YDpk4qmi7izsqeH6n6G021OIUT4wt yslVGocP4BcoKMiOX2uhE4IwIrROCJlausW7dSRRUUTK6SF8F7BW9Va8n79/Tql4Swq/ YzEicyAGD7IlGwAdHm6fyCFdpXJE5RgneKbqeZUYwhoRO5uWG5804EOEEACQGnHnFT26 Apww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4y7BXaK3p6Ev3rLxUss//ZBuzibYMlRBSCu9vxh8o1Y=; b=VE2G5doC7a5CQU3JtbpOCdONlUDC4U1E8Dza8inYJaxKRWv33nP1vqFnIK9KVIQQKK p/C1l5l6KH2rE+0r9rh0q0PwaWuQMcKuJl8j8T0X0hfohmiwg2dRVc+AvQknrwVCe9hU SlRZy+CiwgSNymvptZlG5nDaox51gROUA0oZt3OVFwQu7j4snEIpJlodvnwhQSTKEFeR FT+VRPqFM8EKmF26LKH2QUoOuPhEe7WbA4X8wLGThN7Z9f3AEEjEUwnuiSb8Vps6B7Wp iPPtC4HKtw0dc3pTDoM4SgyybGqnJnzOhjp6NG7chqSsLadBjvg7G6aSvhl7sDagjb/T 5XmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=BSL9HYg6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si11894291oih.217.2020.01.16.08.45.56; Thu, 16 Jan 2020 08:46:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=BSL9HYg6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729372AbgAPQof (ORCPT + 99 others); Thu, 16 Jan 2020 11:44:35 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:34537 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728899AbgAPQob (ORCPT ); Thu, 16 Jan 2020 11:44:31 -0500 Received: by mail-qk1-f193.google.com with SMTP id j9so19746390qkk.1 for ; Thu, 16 Jan 2020 08:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4y7BXaK3p6Ev3rLxUss//ZBuzibYMlRBSCu9vxh8o1Y=; b=BSL9HYg6dKP4eDQO8ZxgXD3fUPn57epnIYfd8yF5xp1iPMgE/zFnY+UYwobWOthu0J nlV6y0MM6WFUEPMD9BshpweVInH9ZUgnc+uJ/uaCO5JdW8saMWTw8J+IcQ2qnbzV/Bmn hkUEhT9/o5uSxWH1Rf18F/jfpcQmgkm3ktLphptZDrakZem0/OOFuriVYYOib4jnTj1l d8ffmDMGHGUdlao/hClAbQlxxjvJ8EPxKWsSB+jJihR+ltOH99Pu3ZD8hJevNOS8nQyo B+YpBEPippvdXesV6mjvcPDThp3TPrvnNdEr/vCc1Enbw8pOYNbFY0udN7g57aZnhsFo hhFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4y7BXaK3p6Ev3rLxUss//ZBuzibYMlRBSCu9vxh8o1Y=; b=p0oJnP3HooQ2i9knuSZ7zwCEeKE9FWJ/uzE2a8zs4auGVBc1tqUs8Xz4O7ikZ66oQa InDoJzrPC/noLOxB7TUpiEbC1QNOlI3M4bIjCaLWthASL09oqmm00TrTwGaYHKdsP9Oo i7oaemoiGY7kG0tX8P2VfGSUND/vN9njagBQiyUwxYalYiERwzv4+FMfIW7c6vLE+iSG horq/T3uM2feuZEzR94opDe4cCOAULbqTIB2l1wRq8+RdbHcsnQZo6r25cR3tPLuUSKU eZAi+zatjoDkQrLAjlyLKz/RF2szFa6blRqhOWm1LYOtM93rAO12I5crIVmHH1TlTT5t hzyw== X-Gm-Message-State: APjAAAV7YDN6xNR+7g0SbgDUBaoRK91SxqO8WaMldwfGDA8uGtQpAOJG C4ZfJh6PWBx5okR+nq9RwYE5uA== X-Received: by 2002:a37:4905:: with SMTP id w5mr16900444qka.267.1579193070001; Thu, 16 Jan 2020 08:44:30 -0800 (PST) Received: from localhost ([2620:10d:c091:500::ae73]) by smtp.gmail.com with ESMTPSA id b81sm10334905qkc.135.2020.01.16.08.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 08:44:29 -0800 (PST) Date: Thu, 16 Jan 2020 11:44:28 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 2/6] mm: kmem: cleanup memcg_kmem_uncharge_memcg() arguments Message-ID: <20200116164428.GB57074@cmpxchg.org> References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-3-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109202659.752357-3-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 12:26:55PM -0800, Roman Gushchin wrote: > Drop the unused page argument and put the memcg pointer at the first > place. This make the function consistent with its peers: > __memcg_kmem_uncharge_memcg(), memcg_kmem_charge_memcg(), etc. > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner