Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7995850ybl; Thu, 16 Jan 2020 08:58:33 -0800 (PST) X-Google-Smtp-Source: APXvYqy1/YQCoyOEepg3X3J6pFUfAO6QJT++YYJZY4oeDWJzObBlblU5oIpupSzk/GT7klnn3KHs X-Received: by 2002:a05:6830:44e:: with SMTP id d14mr2647666otc.228.1579193913635; Thu, 16 Jan 2020 08:58:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579193913; cv=none; d=google.com; s=arc-20160816; b=yG4h93WZBoH4eZe4NDQ+eGiWCxqKjQeE7zwqWi9npzCf/OrXKmaiVdkKHCj87jAzNX co7ZNHZXIUdroNajG4WxgE+oWrxJlH+riYkqln/nY9t2MMJf9mNh9wxWIq60/sNagP5O odp2B1D0Rl8zSe+Ql5K6wJt2VkIm+ffGhi98x/cNhl65zWBW/yBHhiRR+6pWqMlvoOM+ sClisPMB50Wt9AyS/RsL607uH3ftsUtyI9FmtAaVBEUbkuuaFeGNvgSbxCmLpG9H1JdQ PHdaCmBcbKdfEGiEjHW3hlST76nJvsJLlIjwr2mhYIbJYC51BW25H3BXr9x0Clv41ENt tOeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GsiYSmuFtKuj5wLZRSK7q6FdvD1e86UUNMUP3D9245Q=; b=rkuTnIDjlb85YtGZ/gkL0rJK7wCEicdt6ErNT74xwJT/gwg3WlL8w1ZpbrTpssnpwH 5dWzt1a4ys7kfV3GeSASjdJIgsTbvdxL7tEd7t9t6eHl3uxvLaexZcACAZSuaCO9GGM9 1P7QOamTjrFNhFv53lFj5ExbtSyUnWLR06yqijiFmWbsF/NWpF2w/JtniU6fkVa4+X4i OLyalR1JfHI6I5LpQERl9tzuE8vtHdDGvR4N7Xf7c6mnFaVGpKnLTLcLvFFGHu+fVeeI WFiB3/pJbYLtAWwHe4wWv3Jw5bG8HiKLPJFuIf7cakd4q/Ml/3EQzLnA97HsCBlI1t0A PSdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sSQTu7yO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j24si13209079otn.110.2020.01.16.08.58.22; Thu, 16 Jan 2020 08:58:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sSQTu7yO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387516AbgAPQ5d (ORCPT + 99 others); Thu, 16 Jan 2020 11:57:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:44478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387481AbgAPQ5W (ORCPT ); Thu, 16 Jan 2020 11:57:22 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4DB7F24673; Thu, 16 Jan 2020 16:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193842; bh=tTXgJ4yQ2CfwceTQzvDnr1V0GRvj/lrJuLv4lsjxcs0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sSQTu7yODJYF9KtnYEJFrIkZjsIdu7JHU83Ppe3Azwm9lTzWhdpTyWg+1LJI9sOv2 tajoJ07XprTz/U/22DLCqifo8ARcx3QiyRHNIYcksMYXJAAEWenGPcrunUqQzPAj1w N82enLn2M1ef4XALDk445n42QOT+Pd9Q1GEOu4Js= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yangtao Li , Gregory CLEMENT , Stephen Boyd , Sasha Levin , linux-clk@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 096/671] clk: mv98dx3236: fix refcount leak in mv98dx3236_clk_init() Date: Thu, 16 Jan 2020 11:45:27 -0500 Message-Id: <20200116165502.8838-96-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165502.8838-1-sashal@kernel.org> References: <20200116165502.8838-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit 9b4eedf627045ae5ddcff60a484200cdd554c413 ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Reviewed-by: Gregory CLEMENT Fixes: 337072604224 ("clk: mvebu: Expand mv98dx3236-core-clock support") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/mvebu/mv98dx3236.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mvebu/mv98dx3236.c b/drivers/clk/mvebu/mv98dx3236.c index 6e203af73cac..c8a0d03d2cd6 100644 --- a/drivers/clk/mvebu/mv98dx3236.c +++ b/drivers/clk/mvebu/mv98dx3236.c @@ -174,7 +174,9 @@ static void __init mv98dx3236_clk_init(struct device_node *np) mvebu_coreclk_setup(np, &mv98dx3236_core_clocks); - if (cgnp) + if (cgnp) { mvebu_clk_gating_setup(cgnp, mv98dx3236_gating_desc); + of_node_put(cgnp); + } } CLK_OF_DECLARE(mv98dx3236_clk, "marvell,mv98dx3236-core-clock", mv98dx3236_clk_init); -- 2.20.1