Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8065105ybl; Thu, 16 Jan 2020 10:02:36 -0800 (PST) X-Google-Smtp-Source: APXvYqzEet9vL+fVX/jam2b7+uWQioQCRKm4VkFwkc3tmsVxjA3bH52HxYl7E+xcFlTCE/CxDhYz X-Received: by 2002:a9d:6c0d:: with SMTP id f13mr2799764otq.354.1579197756557; Thu, 16 Jan 2020 10:02:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579197756; cv=none; d=google.com; s=arc-20160816; b=IuTF0JRcvYVYWzaqxQmBjFAxcZrZa3eIVLgA5Jr7GK+XIr98kgR+uncuZgMwcAaUNS JslJ5Py/zzCstwrbtKgSBeIhtffKPgtOR3R5QYppRpZXDfBNFZYLqsoHjAiJNPpg453f UDgr4zGh6Yzp4ibjv2eoopqGjeEYROKfuRAxzZfm/3mceePQDWZN89JXqIJFXDVN3OZ7 hRljhRSNe5mB6F2KVCHa63vaxtpK1XL04/kiHFYoSPP27wVsPAXBQwMwBa2wSA1jfKWe 78TTnEnCDjgpZk6XdPTOdKTkwG/OiEudI1JyWHW61nYWjyAhyUPSV9Wo8gF4iNqsfRVN RHzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ut8/tgWJZ/rOrca/HWT8gAUtxrmvZcmHvXtlknD1FJg=; b=OKu4F76+vUIz/ymC9MfTapjxZRFnUGi/nb+2YAholVbpFO7POnqbZa9xp2VRFxgJkj dy7ptm3lpYMRYL2HB62VpmFzbdy98phRZtrrywOAVFVZyx+cbXHUS1+ahtYNzGlVI94C FaiCeiDxi/nAodUXjH5FEETEcdWeoM8L8kvxi6AGju4C2gBCndpI1nS6ibnDPF/Vnc+p BvIMtiEnztDkvA4ypn6lFBJAqHyoItJRrJ/UU/XjHzcLvKEqRNpfKHnwl1toSedg8i+V Fs0cHXQUyhloV6JJjvCRyQ6s9NbOrk2taDeE6d6FMwZdCnzlVfB/7SkDH9ZyutxhKDXo V5PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zxgph0ET; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i17si1474397otr.14.2020.01.16.10.02.21; Thu, 16 Jan 2020 10:02:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zxgph0ET; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394772AbgAPSAq (ORCPT + 99 others); Thu, 16 Jan 2020 13:00:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:59434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391606AbgAPRlm (ORCPT ); Thu, 16 Jan 2020 12:41:42 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB412246A4; Thu, 16 Jan 2020 17:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196501; bh=KANMXqY2ympshQ9I2mDY5g00urWBmk6k715DSTjsi58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zxgph0ETulLmkEZJ3vFHaJtOVLwYL47vEEDIFoQI4JZ+o5LkHPNHfESB42kK9fZvZ ofckfshlNyd+/tLawRh6SxdZxa2va9876W0/B3oPyCO48bNm5tKHqkej1aIQy026b9 3N0LlfGAs/sQ0sS8LYsehItkNsk3SjD+I7WuBN/4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pan Bian , Manish Rangankar , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 243/251] scsi: qla4xxx: fix double free bug Date: Thu, 16 Jan 2020 12:36:32 -0500 Message-Id: <20200116173641.22137-203-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 3fe3d2428b62822b7b030577cd612790bdd8c941 ] The variable init_fw_cb is released twice, resulting in a double free bug. The call to the function dma_free_coherent() before goto is removed to get rid of potential double free. Fixes: 2a49a78ed3c8 ("[SCSI] qla4xxx: added IPv6 support.") Link: https://lore.kernel.org/r/1572945927-27796-1-git-send-email-bianpan2016@163.com Signed-off-by: Pan Bian Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_mbx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index c291fdff1b33..ea3b77ba12a2 100644 --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++ b/drivers/scsi/qla4xxx/ql4_mbx.c @@ -641,9 +641,6 @@ int qla4xxx_initialize_fw_cb(struct scsi_qla_host * ha) if (qla4xxx_get_ifcb(ha, &mbox_cmd[0], &mbox_sts[0], init_fw_cb_dma) != QLA_SUCCESS) { - dma_free_coherent(&ha->pdev->dev, - sizeof(struct addr_ctrl_blk), - init_fw_cb, init_fw_cb_dma); goto exit_init_fw_cb; } -- 2.20.1