Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8069873ybl; Thu, 16 Jan 2020 10:06:46 -0800 (PST) X-Google-Smtp-Source: APXvYqzDiOgZkXY03siSQSg2N6NPCW3R6W4E4Eu+6WBOYHlFOzgMF2ZtCbCpD1On5cr6tVGJBsLU X-Received: by 2002:a05:6830:2014:: with SMTP id e20mr2964235otp.272.1579198006558; Thu, 16 Jan 2020 10:06:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579198006; cv=none; d=google.com; s=arc-20160816; b=t7fYzk8PBFZwFfYZx2NnuVNi7MJ8Nneo+RQF2tRCiO48jTjsyWu5DgKx+mbvzTZhWl mHsQr/9ULLQYCFWu+ddnz23csiSsrd8OtlyzwCLFBvtMaxwRFWjEge/VJ86MEtrV4jPm e7aKPbX7aOoUrIY33zfnjJ9+45U878kml5xK8BS5UujvBx29KwBQRNW065941huR/cK3 nqmy0Jqc1e77lB6WAwPMm/cSPzhBc+bMAltQGr867UIY4+KjdEoGqbh84vs51nmA4DTF 9Jq0uBt5YalRjrI5q4i0a+lIkPHrHECFSLZ+KSA3B2wtQkQHkPmscZwHQTojgXUCLEYl DSYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kHa9WhJx2kjqJXi5EeL8VQjWAMY/VWK2WVwqlL405Yw=; b=K0j6Zrsd56QnT0oTsbNB3l+jxf+nA/Xo9BY4vrhzzZeVcUKkkhkbB0aJDw/lfxi1JP 5NHcj+t8c/a0mWIPdzib9PlBQg2SjJVK98ecPkmp4ra9PcY43uxwpvxR1r+FYMEAkq15 WRF7DKqLABhjPUGz1IGbtxXDeIOH2KAi26pdyS3UtTbgQ7APArPQ+xSuNBwYcgmPEA0J kb/i80GGt4D31MwBZIPm+8VNB5F7R2pn/6QxS61HlvXg0AQJehvF9w6MlgOWTV12fiJ9 W3WnkCSOOc7+nARvrc1N8abmNGebEzhUTz7Lpik56/XNEEy4/TBcyBkkOPQ8O9Q1Ls/7 KGMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XqCp7b8m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si13584011otf.246.2020.01.16.10.06.34; Thu, 16 Jan 2020 10:06:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XqCp7b8m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405572AbgAPRkm (ORCPT + 99 others); Thu, 16 Jan 2020 12:40:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:56238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393499AbgAPRjm (ORCPT ); Thu, 16 Jan 2020 12:39:42 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 246122471F; Thu, 16 Jan 2020 17:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196381; bh=HGhx/zmL8/C/mfUQHP9jB2DLzEnwQZgZWd7IWiSc1eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XqCp7b8mNJ/MgMyXnwu+sLrw5E868dxJh7fQlXWcGrJvQBi2vwUhHaeazTVq0M3rs 3pa2y3kJkCKqERsfEAVJIJvCqszsQEIiKAiIacAn30KHGRRUmd8p86M1A2UYIp3NuA cozM5Bh1YujEUGzU4PBYOHNqFOjBHU86hklaROBs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: David Howells , Geert Uytterhoeven , "David S . Miller" , Sasha Levin , linux-afs@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 164/251] rxrpc: Fix uninitialized error code in rxrpc_send_data_packet() Date: Thu, 16 Jan 2020 12:35:13 -0500 Message-Id: <20200116173641.22137-124-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells [ Upstream commit 3427beb6375d04e9627c67343872e79341a684ea ] With gcc 4.1: net/rxrpc/output.c: In function ‘rxrpc_send_data_packet’: net/rxrpc/output.c:338: warning: ‘ret’ may be used uninitialized in this function Indeed, if the first jump to the send_fragmentable label is made, and the address family is not handled in the switch() statement, ret will be used uninitialized. Fix this by BUG()'ing as is done in other places in rxrpc where internal support for future address families will need adding. It should not be possible to reach this normally as the address families are checked up-front. Fixes: 5a924b8951f835b5 ("rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs") Reported-by: Geert Uytterhoeven Signed-off-by: David Howells Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/rxrpc/output.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index 59d328603312..64389f493bb2 100644 --- a/net/rxrpc/output.c +++ b/net/rxrpc/output.c @@ -400,6 +400,9 @@ int rxrpc_send_data_packet(struct rxrpc_call *call, struct sk_buff *skb, } break; #endif + + default: + BUG(); } up_write(&conn->params.local->defrag_sem); -- 2.20.1