Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8072404ybl; Thu, 16 Jan 2020 10:09:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwVVAVK3Nbzm9iRIg8ImbMouAAJVfgCNArDWoUrNp6tTt5UDCs3F+4OnIZ9oGlQSKWMsjr7 X-Received: by 2002:aca:fc47:: with SMTP id a68mr269954oii.52.1579198144746; Thu, 16 Jan 2020 10:09:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579198144; cv=none; d=google.com; s=arc-20160816; b=RKEB2HS+xbET83YTaqL2iAv2ttJUz2GrpGaYCWly5qEOoV4IjJk95IBJpXeHthV5BK 5BhJMz3hyz72ILV1zvyzqPiKwoNuWvyyoR5YOauTfEkxJiWQFPkDvC+7z1O3ThHqlyWL M/rdrKYYtt0gWtis689BCOlcfgbJsJbfm0j83yxNiEV1Y2ziafK+yxoo2jXTjkSFK2n9 W0LJbjt79cPY6sfNxrlxebGtqFaY541fpTFgbR8b0TtccFtsAa5opJCVmf3QvaIJGJMw Z1E4z6HbpMP5qIChh+VA92Nveof2wVC1t6im2Rs4a6Pjrsp2TNYr51mjpW4jf4oJDWGk gpag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UFribP/89ZELECvdDU4XwlKhaQjSGkGsGBeqf6iVSZc=; b=qrEh9gEB44TUS01aeYjPCL/dGXLewJgnvsgw/jM303TDyILkPCO8TOM2hm2VHDOtRn 8moR5B9nxkj663phdKkAxvBWUlhoF3PFN+SL25yf7kDEedc1mm4NJcrN33xHP8Jh+d1n HRvT+XCs3Nk858N9kn8N/GkjxpNbXWAMj1//Ihqs2PcFeUmGmJX7GUCBpOKflepRYvKZ FVm3qCYOvHZM0Zc2bKCIh7LYmK4P87MsHsDSKFc2osBF8aOuB+WzmHiOXE2vVm1VMnCq IsJ9V8tRMMZDtNjp4ZWBH1N2UBp5m9TEjra5RSuo4yGxK2ZXY2bpPkD0ecLDX+GWp5kB EZ2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hGgR8rjE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11si12016207oic.176.2020.01.16.10.08.52; Thu, 16 Jan 2020 10:09:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hGgR8rjE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394999AbgAPSHf (ORCPT + 99 others); Thu, 16 Jan 2020 13:07:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:55120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393419AbgAPRjE (ORCPT ); Thu, 16 Jan 2020 12:39:04 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A021246D5; Thu, 16 Jan 2020 17:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196344; bh=5KK9hVvP7HtS8Nhi7+wZ7prpIoAH8W+uEaDpuuwJxjc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGgR8rjEwWhZNbq+9/CxhhD+hRW89aA1/58j2S7o0qD4Ts8LLnrUnhAn0+SG2Tb9a 67P/mtEmrQmjAj9NP+p3DNMYpklyQWSwgiIVh2OrRbfp8oULcWXBJYbvausi23F4Ue 1otD4HC4PNPCsYkCOXEit02KDtl+M01JazjfPD1o= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Douglas Anderson , Daniel Thompson , Sasha Levin , kgdb-bugreport@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.9 140/251] kdb: do a sanity check on the cpu in kdb_per_cpu() Date: Thu, 16 Jan 2020 12:34:49 -0500 Message-Id: <20200116173641.22137-100-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit b586627e10f57ee3aa8f0cfab0d6f7dc4ae63760 ] The "whichcpu" comes from argv[3]. The cpu_online() macro looks up the cpu in a bitmap of online cpus, but if the value is too high then it could read beyond the end of the bitmap and possibly Oops. Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)") Signed-off-by: Dan Carpenter Reviewed-by: Douglas Anderson Signed-off-by: Daniel Thompson Signed-off-by: Sasha Levin --- kernel/debug/kdb/kdb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 5a58421d7e2d..a52a6da8c3d0 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2632,7 +2632,7 @@ static int kdb_per_cpu(int argc, const char **argv) diag = kdbgetularg(argv[3], &whichcpu); if (diag) return diag; - if (!cpu_online(whichcpu)) { + if (whichcpu >= nr_cpu_ids || !cpu_online(whichcpu)) { kdb_printf("cpu %ld is not online\n", whichcpu); return KDB_BADCPUNUM; } -- 2.20.1