Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8076869ybl; Thu, 16 Jan 2020 10:13:08 -0800 (PST) X-Google-Smtp-Source: APXvYqwSxDNuIRycvnNiMHiq5zBTwo2DFmDMSSl7Z+XPAOlqwvLlePgRYU4xe0B/T6A+YW+BRML9 X-Received: by 2002:a9d:4e92:: with SMTP id v18mr2917032otk.47.1579198387789; Thu, 16 Jan 2020 10:13:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579198387; cv=none; d=google.com; s=arc-20160816; b=gtxNot8ytduSivvHDjayXDLmFyJ9Ccli7XQ5lxEIuTttYcwvHdiTgN/wYIBvkk6bl7 OKGH2yV004Gwshb0JmlOqjLoF55x3KyoUbS/Ld1RxfMskS0vW2+DpRGmwPAoFAI8RAHJ rm/rC4sZidxuu5vbI/H4ePeqIuW2i9w/KBlJsxOHc+4/6VymAQKjFVG33IFWw8ohobb5 MKS0XKWDvuZerJSIDGR/trjCSuq3kDpx/SjNuZtxZ8F3V+eA6RQx6AJMGmXLnbdI5T4/ /YIxfXogkq15e/RdRWbVZV7soMBWYxJHBx2KVPryQtTbEPE9L73uIgaKUJOb7+NgUa44 XtgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zMjUTe2eliMyz7uZZRiaiIxOXhRXSC/G4ZDiPx7/heY=; b=cxj9qi3ixvxL4jQoHEEmWfao+QWHfJSF5xZCrP0ycBzwDvhNHq6GtwwOMGLi7+Ik2a TimvjbRXNIBNOimjQ7RYML1gzO5EMegUaSKv1U2UdF2djvBXbpVO6R85MNi18HpZcM5I AhmEyb7RRaSIRQQ63wQH61yvL8CFtlv8ensJDnLnQ1in5PI7wjJyxcBIMfAnNVwSOHbd vDCDvlnsSgTmWr0jnOG0YOrzcB4KgilXowuVR9gvFWe3TV4+N24wJK6VX/1T3KD60IaZ gC9hNxUDdiWF+3PNe1UnSAQdSZpSzfDKvW/NpuzpHELI7l0f4ooducnxbV4SBGTPJZZC V5wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=chkNu0Aw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si11896315ois.221.2020.01.16.10.12.55; Thu, 16 Jan 2020 10:13:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=chkNu0Aw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405366AbgAPRh2 (ORCPT + 99 others); Thu, 16 Jan 2020 12:37:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:52502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405332AbgAPRhV (ORCPT ); Thu, 16 Jan 2020 12:37:21 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C5CA246AD; Thu, 16 Jan 2020 17:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196240; bh=QrbJSSFGZoHv8Kamr1uDkgCuY3Gp7yodECR1MkQoYUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=chkNu0AwsCxlDZaggyuODNp2g5mQ595K678IEpslIEmTAVN7eS73PWyNXKj+to6j4 gs7A8VaMBGtORmuuTw+U0gwvTfBvBPy0eG2ohmtsrZzjgPhdSY5Bqqfr2UGE/Ta/jS VgxpN6Wa7WiWLrLWom4Evcs6BbRkgCQxg50fuECo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sven Van Asbroeck , Tony Lindgren , Bin Liu , Sven Van Asbroeck , Felipe Balbi , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 070/251] usb: phy: twl6030-usb: fix possible use-after-free on remove Date: Thu, 16 Jan 2020 12:33:39 -0500 Message-Id: <20200116173641.22137-30-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sven Van Asbroeck [ Upstream commit 5895d311d28f2605e2f71c1a3e043ed38f3ac9d2 ] In remove(), use cancel_delayed_work_sync() to cancel the delayed work. Otherwise there's a chance that this work will continue to run until after the device has been removed. This issue was detected with the help of Coccinelle. Cc: Tony Lindgren Cc: Bin Liu Fixes: b6a619a883c3 ("usb: phy: Check initial state for twl6030") Signed-off-by: Sven Van Asbroeck Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/phy/phy-twl6030-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c index a72e8d670adc..cf0b67433ac9 100644 --- a/drivers/usb/phy/phy-twl6030-usb.c +++ b/drivers/usb/phy/phy-twl6030-usb.c @@ -422,7 +422,7 @@ static int twl6030_usb_remove(struct platform_device *pdev) { struct twl6030_usb *twl = platform_get_drvdata(pdev); - cancel_delayed_work(&twl->get_status_work); + cancel_delayed_work_sync(&twl->get_status_work); twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK, REG_INT_MSK_LINE_C); twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK, -- 2.20.1