Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8160085ybl; Thu, 16 Jan 2020 11:40:03 -0800 (PST) X-Google-Smtp-Source: APXvYqxeRlddB/Je0UC/oynFukVV0rq5aVEgGmRx0xRhXkXDpbK88xBCBvZrempb8ufM8Yb4udRq X-Received: by 2002:a9d:7586:: with SMTP id s6mr3305681otk.342.1579203603719; Thu, 16 Jan 2020 11:40:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579203603; cv=none; d=google.com; s=arc-20160816; b=SeTh872n7Ipki0+UreQNpVY8FluJnoHr6+uJQykOAa0KgtfzwRyP1Gb8XzqaQdGPGF DzNx6Bc8OVHb0JFYJPEJPCOyk7LextK3UDnyByM0oQ9wtPSJYyxMAq8TSUU0rJ0TSRUu AbZGZWzcrIY9GBNzZqtZzAsjpYky7VdYOzZpQGkHcM+iTHZ5Nh8IUp57ozt7KQVQ1lQj oJ0+/M2XYYjsnFvZj/tw3JW7ZzcOoXjw6LvSvk1+3TXM15kFEhJviLAh/plLg3XBjIYx ByGuP+XMkMqZ1hT1A+umcoma6iWt6l9cclN726Zhc8DwA0uD7RyPqLB/nDxR1mOzTyrz hl0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TrsmU2SYNJPB3JR+h6a8mWUS19eYkuvsaOoej9YsuQ8=; b=LH+JPqVYEKIJxcTZLyt1ZfYlTQ7445SlAR+KkmWIG0Bi4fMc8zCCCwi5NW4TogKJRD kMkAFgCnvPUR3Ywc0C+ZkD6DhdQoIqvOBTvdJTpW3A4Bad+WdSNzALP1GWk0xvz2Zy8F pV60TLptbhyelB3DoxDx13ty9LCmEzB19GqEvQ+vN+vhhaa4aJdBYcp+HRyq5PfOK7hZ Sm+ih8vF89IVMj7e0fQE7lDKNTKZ+IspxEc6lOaId81u3PMF+1sbyEzDfCzL+bcr1BGc mLFm5CIvfGPhugX+wgfGUpf8yBk/xNRDlAHabL4nGRsUwG4Saw779NgQuLkp4mmpSn7G iJZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="nZJzo/G2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b137si11718262oii.63.2020.01.16.11.39.52; Thu, 16 Jan 2020 11:40:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="nZJzo/G2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733027AbgAPQze (ORCPT + 99 others); Thu, 16 Jan 2020 11:55:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:40638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732792AbgAPQzZ (ORCPT ); Thu, 16 Jan 2020 11:55:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFC6122522; Thu, 16 Jan 2020 16:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193724; bh=bbNkedQdnDzdtuUlAZ2NagqN5EXVfxVOs37adHQ4BEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nZJzo/G2HLWjfXwgiP9E493ETgx21Y3sJQQMlGULYOk0ku3sqXHLc1FULYRJhaSOk GvpzDlidoGbFLCvofUxpRZsOyG8XwBh8wezrnGs4bGbAbH3dgvdo45cwofUSGJ8QDE 41KE4O0128ytpB0k4MmpZzNTig7sTOznomoVaOVc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Houlong Wei , Dan Carpenter , Philipp Zabel , Jassi Brar , Sasha Levin , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 018/671] mailbox: mediatek: Add check for possible failure of kzalloc Date: Thu, 16 Jan 2020 11:44:09 -0500 Message-Id: <20200116165502.8838-18-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165502.8838-1-sashal@kernel.org> References: <20200116165502.8838-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Houlong Wei [ Upstream commit 9f0a0a381c5db56e7922dbeea6831f27db58372f ] The patch 623a6143a845("mailbox: mediatek: Add Mediatek CMDQ driver") introduce the following static checker warning: drivers/mailbox/mtk-cmdq-mailbox.c:366 cmdq_mbox_send_data() error: potential null dereference 'task'. (kzalloc returns null) Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") Reported-by: Dan Carpenter Signed-off-by: Houlong Wei Reviewed-by: Philipp Zabel Signed-off-by: Jassi Brar Signed-off-by: Sasha Levin --- drivers/mailbox/mtk-cmdq-mailbox.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index aec46d5d3506..f7cc29c00302 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -363,6 +363,9 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data) WARN_ON(cmdq->suspended); task = kzalloc(sizeof(*task), GFP_ATOMIC); + if (!task) + return -ENOMEM; + task->cmdq = cmdq; INIT_LIST_HEAD(&task->list_entry); task->pa_base = pkt->pa_base; -- 2.20.1