Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750917AbWAaO4o (ORCPT ); Tue, 31 Jan 2006 09:56:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750920AbWAaO4n (ORCPT ); Tue, 31 Jan 2006 09:56:43 -0500 Received: from ra.tuxdriver.com ([24.172.12.4]:2056 "EHLO ra.tuxdriver.com") by vger.kernel.org with ESMTP id S1750915AbWAaO4m (ORCPT ); Tue, 31 Jan 2006 09:56:42 -0500 Date: Tue, 31 Jan 2006 09:54:36 -0500 From: "John W. Linville" To: Denis Vlasenko Cc: "Gabriel C." , da.crew@gmx.net, linux-kernel@vger.kernel.org, Adrian Bunk , netdev@vger.kernel.org Subject: Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error Message-ID: <20060131145431.GI5433@tuxdriver.com> Mail-Followup-To: Denis Vlasenko , "Gabriel C." , da.crew@gmx.net, linux-kernel@vger.kernel.org, Adrian Bunk , netdev@vger.kernel.org References: <20060130133833.7b7a3f8e@zwerg> <200601310810.33107.vda@ilport.com.ua> <20060131100330.2931cbe9@zwerg> <200601311416.05397.vda@ilport.com.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601311416.05397.vda@ilport.com.ua> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 29 On Tue, Jan 31, 2006 at 02:16:05PM +0200, Denis Vlasenko wrote: > CONFIG_ACX=y > # CONFIG_ACX_PCI is not set > # CONFIG_ACX_USB is not set > > This won't fly. You must select at least one. > > Attached patch will check for this and #error out. > Andrew, do not apply to -mm, I'll send you bigger update today. Is there any way to move this into a Kconfig file? That seems nicer than having #ifdefs in source code to check for a configuration error. John P.S. Please post any patches with formatting according to kernel conventions: http://linux.yyz.us/patch-format.html -- John W. Linville linville@tuxdriver.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/