Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8264569ybl; Thu, 16 Jan 2020 13:32:12 -0800 (PST) X-Google-Smtp-Source: APXvYqzIiXyx7eYYtqF8zjCGAf7K99pDc8+fAv4HYgF5SxRMlHJA5/m2wASonxh3S8IdcZjHIdYq X-Received: by 2002:a9d:3a66:: with SMTP id j93mr3856793otc.25.1579210332293; Thu, 16 Jan 2020 13:32:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579210332; cv=none; d=google.com; s=arc-20160816; b=gQrhygP0STaB7DnmMUyWsFvMoPaaNJnTseudbvtQOHhz0/KBQck5m0Et2lsMj8A81w 5TyYEC6tdrutFxRJU2l13sLxCQKvFvMbBGgKYFvGfFSk2Q8Mgo3Bl2BsreGQ22Ls76mj 08F8ekWm5KhTLxaNoPmOY1Jl/MFZiEA0lrQFlARq+lZtS/KCixro9Ok/FwbJSj2KNf/q EXgGoQ124oKd/QLh1Hgkya2mMNdDrrffGY6Ol0UsaeU4zouBGwInxDWo+RGxPKKKUSIH G9YhSdAlfDOPt27HnWAuzoHTSb2PSudlTJ7gVkiSqYcVnJm1BE+/ZRr+djsBX7kLqfEL C9aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jbLerYJKIw6pZqNOeBA4ueAifL2rKUhXhNtFUS1N57E=; b=bhtj7KmaYWr/ej3pqeDNwp7PD5AuJJaHS5reGP6eldiR90ldjhczvYHyvhVEQXQ8e/ PKwPcKcM4VXTTR6Xj5O02PUJTJ565j0nJ2/DwOGyvuQU+aWUMfr0MR8BT0rOoPD6rplF fe0saYMuNV2BtZN+LrCJtxNA7ZGJM3MInOR0rS21WKqnR/oqFbT5EHz1RM68hPwDE7T8 Y8ppK1lLIilOvGBjaQ0P+A4hUaf5DR1iGIoTYvq2LVjC6GcfehvMkr4XAATBRy6FYY6M TWD5Ahv4qpNyzFrL5lCALlz8kkr2+q+LmTQC/Ym8m7J0TvSDepOBurOZ20MrXilg+7QW et6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1J2WK9Wp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65si585863oif.14.2020.01.16.13.32.00; Thu, 16 Jan 2020 13:32:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1J2WK9Wp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405163AbgAPRgt (ORCPT + 99 others); Thu, 16 Jan 2020 12:36:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:51640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405114AbgAPRgq (ORCPT ); Thu, 16 Jan 2020 12:36:46 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4BCD246B7; Thu, 16 Jan 2020 17:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196206; bh=tdBSwxxCeitoPSZ6ScJGChgxmx8QvubbLNKi1Z1+VLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1J2WK9Wpn4tiGkOnvwmbOtY9vvj/P80fWOTw7c6V8S3kteToX0GLgdFYrX3QUDKiv xUgjhWJcqa201SuZAZFxAC0r+JlLIBdt3pj7Sa4oDSUc4TTWtfBuOdqOHprPzibiDQ BApSyJvMGDmR2CymAwsJN/3Rb9xC9T8ELlCqljc0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stefan Agner , Daniel Baluta , Nicolin Chen , Fabio Estevam , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.9 043/251] ASoC: imx-sgtl5000: put of nodes if finding codec fails Date: Thu, 16 Jan 2020 12:33:12 -0500 Message-Id: <20200116173641.22137-3-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Agner [ Upstream commit d9866572486802bc598a3e8576a5231378d190de ] Make sure to properly put the of node in case finding the codec fails. Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000") Signed-off-by: Stefan Agner Reviewed-by: Daniel Baluta Acked-by: Nicolin Chen Reviewed-by: Fabio Estevam Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/imx-sgtl5000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 8e525f7ac08d..3d99a8579c99 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -119,7 +119,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) codec_dev = of_find_i2c_device_by_node(codec_np); if (!codec_dev) { dev_err(&pdev->dev, "failed to find codec platform device\n"); - return -EPROBE_DEFER; + ret = -EPROBE_DEFER; + goto fail; } data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); -- 2.20.1