Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8264639ybl; Thu, 16 Jan 2020 13:32:16 -0800 (PST) X-Google-Smtp-Source: APXvYqxcYqOI7Wx4D6TMWYX5OeuO46TVzC/LatEhrgRWzL6H50cW0wPmjvTp9PmWL7cRwHkFfWHN X-Received: by 2002:a05:6808:f:: with SMTP id u15mr983430oic.100.1579210336042; Thu, 16 Jan 2020 13:32:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579210336; cv=none; d=google.com; s=arc-20160816; b=UtI0PnyjWjWzNnYnN05fL+eCWOknXIPRsH1/uFuP4yAvntovqXAAX6/s7/viSY7cZe fGVx+FcNNG2Vn1XzJGUwcRPW2RTSrYfeHXspS/XhPZ/59OGW5EsPHdwfhEZiXStifgt9 c312o4xNOl3HAwQ97F68jFJ26TPXh9Fcea3HONYSHfQ+otOkC1XbUGoCMZlI4EMEvF4s Qz0l+eifkyc88inyv10WOxvv+FJsavyFD/BjbkYzKtqC4ANNxjRORpYQ55GUcro/gS4O uTmDLipKNFsdTB767qxVBejFLF0mYo5Hf23FTHNvwgcxbzxIgP3QGFwfyWQ+/caErGxM o/zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1PyNs29QWWVg+KSt6WL/+XiS5ykqkVTG8XHJw7eRaBs=; b=gOIxXVxDZPZBJmpmZA7c/L9ju+IFnuY+Wpu4Bg2RQkV9nYFOCDovgK8Chpu8BzIodm jd4pyIUIZREEcHAlNp8dwhs/VRk7DF9qgXiKOadXeAsstIoLk2ise6mQzTuDBD5k2q43 nepScugtAwaRGx7p6EOpvsogWRXj7FSIIErKUYa/7WdXnKPxarl/h9GAXS4xeBCsKDdf sAkjBU4RuiRCQbqOjAzn0T6Fm5iOQNZLARAE9qza/nw+vM9leZzuzuFVSJkrr9s57tTM PFTUeW5fMOyVFXlSj8/+I+ceRyfAPkRA3O+Ya1evRn/NQywePecMc4Ov0xjEU0VwZMtG lGRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kYQhNQxJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a23si7677349otr.244.2020.01.16.13.32.03; Thu, 16 Jan 2020 13:32:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kYQhNQxJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405214AbgAPRgv (ORCPT + 99 others); Thu, 16 Jan 2020 12:36:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:51752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405175AbgAPRgt (ORCPT ); Thu, 16 Jan 2020 12:36:49 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C3214246C6; Thu, 16 Jan 2020 17:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196208; bh=DD5b3OtEOuYFjYuUz0V1Ew0UTKdSxEIPHB7MzvFpuk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kYQhNQxJ6UfgZpJmQoY87xwJTY5r7K9Z8WCb5lV5VEjcNQayKsB3Kl7xPT9efVrp5 XXi+ag+eiJhDd92zzqBVyOFwvhHyyRkBbRwS4c/ZFIrkQksFtDY39zsgWhS/O1uBHT O6G6/pE2Li3DXgfAJhc5gf/gKNcLUZR4yZag+Ho4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Eric Wong , Alexandre Belloni , Alessandro Zummo , Sylvain Chouleur , Patrick McDermott , linux-rtc@vger.kernel.org, Sasha Levin Subject: [PATCH AUTOSEL 4.9 045/251] rtc: cmos: ignore bogus century byte Date: Thu, 16 Jan 2020 12:33:14 -0500 Message-Id: <20200116173641.22137-5-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Wong [ Upstream commit 2a4daadd4d3e507138f8937926e6a4df49c6bfdc ] Older versions of Libreboot and Coreboot had an invalid value (`3' in my case) in the century byte affecting the GM45 in the Thinkpad X200. Not everybody's updated their firmwares, and Linux <= 4.2 was able to read the RTC without problems, so workaround this by ignoring invalid values. Fixes: 3c217e51d8a272b9 ("rtc: cmos: century support") Cc: Alexandre Belloni Cc: Alessandro Zummo Cc: Sylvain Chouleur Cc: Patrick McDermott Cc: linux-rtc@vger.kernel.org Signed-off-by: Eric Wong Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-mc146818-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c index 2f1772a358ca..18a6f15e313d 100644 --- a/drivers/rtc/rtc-mc146818-lib.c +++ b/drivers/rtc/rtc-mc146818-lib.c @@ -82,7 +82,7 @@ unsigned int mc146818_get_time(struct rtc_time *time) time->tm_year += real_year - 72; #endif - if (century) + if (century > 20) time->tm_year += (century - 19) * 100; /* -- 2.20.1