Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8265706ybl; Thu, 16 Jan 2020 13:33:21 -0800 (PST) X-Google-Smtp-Source: APXvYqyDe3K9YTCgqGo22jIZ0q0CY+xX5cYVdOxDLv9NpvJwhjop/5fKnMLI2Pi5geXK/FPFfdI3 X-Received: by 2002:aca:1a06:: with SMTP id a6mr924984oia.148.1579210400893; Thu, 16 Jan 2020 13:33:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579210400; cv=none; d=google.com; s=arc-20160816; b=uEVedwZnkwK+qOOZYeHlLGnLh057fXI5WfnLsK0wG6nSXmLe9P0A8ZrYioLC0k5Dr6 aSpcXn56z1LU1HO4gQSH3+TmU0if8roB4F10UEZSNTpFS1QwzFK+306EuqzUEhCB4xtW F7GJDL/XvhfYMn7IzljfNL+PLe2GNde2EtL7ugzTut8hhCz919uhV5e+BW2s22meaK8V yLVma3mUsEUQV0saUgXnXow/DyBQThfDUi+47oMFsnnjhcIM7PBW//d8gMCZD0pOxRt3 yA3pkEQGBuuFbIQbyl7pAQwQ3Lw/fg155Jxg35WnVvUDg14D2V6ulC27a4/Rmucr/m26 6cwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gvCvbOEzfGWV6fr02ONkWbGmMb3IeQR3PGA13cvrkWI=; b=riq8sPb2B7eiY/LBOhUoKI801uxqyuKzV1pie0u6oGZdQiQo/yi0yr6q/us0u/UjWa mAFvN4JX8vi2FJoYoWbvsVEHqAderzltV1m/HyTvIh/J9b3T/lN0Y5JqqGIwmdM7BnC7 8/jOBgpa5zv6tDHiXyrnJ2vZBPbCBat5GsFRwr1/pBMDTq+oOKwyety2ngA2UxHGRzR7 6DOYek3Ha22qUqhH1PiolMOukhIYUbLFsI3Mt8Fj/p/Oqo10VxGV53wzd0f3625NutOI TA2bMW5WPCF3GNjiwBQyz2uSMpJM+VeyDSfNbllF7zPF3QxtnRDhY710P+RvQONtmQ/F 0ONg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a8QemdCD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l11si12438488oie.231.2020.01.16.13.33.08; Thu, 16 Jan 2020 13:33:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a8QemdCD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393528AbgAPRjq (ORCPT + 99 others); Thu, 16 Jan 2020 12:39:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:55040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393403AbgAPRi6 (ORCPT ); Thu, 16 Jan 2020 12:38:58 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C952246FC; Thu, 16 Jan 2020 17:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196338; bh=9ylBcB/tQCcPvViPr7XtyStbO6ARp/VIC4GaqzyRXIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a8QemdCDDqTECeBlT9ZQHvxbl7qkaYZh2lFHpRrYuNw+FjfvJhqeycWxHkVtuUy40 su/yrq7FEOj1G8/tXdbLpEMMTLnrMdPOtx5BZbBGaqj1TVogxc/XOJAUOoemJN6ezS Om/9+OhXOoH5ZshvPAVS6JIHZpAI0DEAy+07jnBU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Mario Limonciello , Andy Shevchenko , Sasha Levin , platform-driver-x86@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 136/251] platform/x86: alienware-wmi: printing the wrong error code Date: Thu, 16 Jan 2020 12:34:45 -0500 Message-Id: <20200116173641.22137-96-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ] The "out_data" variable is uninitialized at the point. Originally, this used to print "status" instead and that seems like the correct thing to print. Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status") Signed-off-by: Dan Carpenter Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/alienware-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index fe419935041c..bee2115ecf10 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -570,7 +570,7 @@ static ssize_t show_hdmi_source(struct device *dev, return scnprintf(buf, PAGE_SIZE, "input [gpu] unknown\n"); } - pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data); + pr_err("alienware-wmi: unknown HDMI source status: %u\n", status); return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n"); } -- 2.20.1