Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8266015ybl; Thu, 16 Jan 2020 13:33:42 -0800 (PST) X-Google-Smtp-Source: APXvYqwvtdUfnNcHFMbsB4+scjq8Ukehzts+k2WU/tpi57Z2aC11p4DCPOKnSf6/9JdhW14O7/L2 X-Received: by 2002:aca:d4ca:: with SMTP id l193mr941383oig.133.1579210422815; Thu, 16 Jan 2020 13:33:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579210422; cv=none; d=google.com; s=arc-20160816; b=QOH30ehiRDyR/K3sSG6EGF3N2MiLMF6zqwF5lS/eLnH6tBXLe564kHbdxYG98FaBKh LzW276ZPOzsbS/ZNtPuvQ3ENgaVhG3MXoj+XTdUAniOVWLvcHtMcKc7cLsy3EYBmoVW3 tl20G/gzMLKOolNbZUbPIra7+LJMMj2pHX/dMHWl4zuNWSPDYAHRPvyihYjxKiUvtNVD ayQJpzdRS09pHW48bdikDa69bLbFkieIYOSgbLdH9WzgHjBM9TfIE5ile82Uw7L/5frG hJcFTj7/sy4uht31SlhFoOSJYQI/IdOHWa8iN9Gij1SHGLtN761enUlLxxzKs41gRfcv jprQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4/qpCPkaBhQXmvzc4erNtFEOA3DaZOAgwwOUZUnq2NA=; b=l/UwlM7hyKnjhZzsjwUT5vllbuMjGLYftNieJ+l8O3YcTVxRLpSSANTue4yALgCmj6 1VjIN90wQr4KnkDEPHMM/lkcudVCCPcrHzyDf2XMAycIckWl68dNoquqKs2gL+ah88Al hT+kSNHuwyMfs6WD2XyGtYaABJc/ASQpMepSa8CkOcqm83hSeZ6qxV9IYoPfBb2nW3VV KAkizkErWABMnPw06MSWabGv1uurvqMODSJxRXzsm2OOjQl+7+XQNqDonORmGp4z58Qi teaqF1DQytVgHTFBKM4Cpw4NmdK4tVA3/V/CJOjwWnFaEznN2CwApyjaodmMliD1YfJi wOhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cJu4ewnJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si13342342otn.100.2020.01.16.13.33.31; Thu, 16 Jan 2020 13:33:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cJu4ewnJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405053AbgAPRie (ORCPT + 99 others); Thu, 16 Jan 2020 12:38:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:53574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388572AbgAPRh4 (ORCPT ); Thu, 16 Jan 2020 12:37:56 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4012246E1; Thu, 16 Jan 2020 17:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196275; bh=Er9b+hegv+QekdwOFBDM4vu7+PTEEUZ/66FnFh24PYQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cJu4ewnJLHGQupC3fV7PAxuYF9CBhEYKxUS32JXK+cIVS1PCl2oXA9XokisyWU1+1 TFOGEuBSgFAXikQXd9pp9ocGiQ4KwEya+OeVlLPr1yeOkJndRT7pEHbdHUyvoaVKo3 B4zRVLOWBAmK54F0tfuKPuy4dmj8u3Mozaeidnl0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 096/251] media: ivtv: update *pos correctly in ivtv_read_pos() Date: Thu, 16 Jan 2020 12:34:05 -0500 Message-Id: <20200116173641.22137-56-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit f8e579f3ca0973daef263f513da5edff520a6c0d ] We had intended to update *pos, but the current code is a no-op. Fixes: 1a0adaf37c30 ("V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/ivtv/ivtv-fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ivtv/ivtv-fileops.c b/drivers/media/pci/ivtv/ivtv-fileops.c index c9bd018e53de..e2b19c3eaa87 100644 --- a/drivers/media/pci/ivtv/ivtv-fileops.c +++ b/drivers/media/pci/ivtv/ivtv-fileops.c @@ -420,7 +420,7 @@ static ssize_t ivtv_read_pos(struct ivtv_stream *s, char __user *ubuf, size_t co IVTV_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc); if (rc > 0) - pos += rc; + *pos += rc; return rc; } -- 2.20.1