Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8267650ybl; Thu, 16 Jan 2020 13:35:26 -0800 (PST) X-Google-Smtp-Source: APXvYqyczy2MukpnRVBiDQInEY9iPZviQ8WVn29WU/jU7QA26F/fko3oJ49R0dWOWQFeGnq+d0Ac X-Received: by 2002:a9d:5c1:: with SMTP id 59mr3792400otd.192.1579210526751; Thu, 16 Jan 2020 13:35:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579210526; cv=none; d=google.com; s=arc-20160816; b=HBvNPPTSHqVBxORoIsuuQubD7UaWgd8dFIV5D2951spYktvfD5h30Czjzq4FfBm6oE SSuw/xHTMxUt4IAPiFDQPPTk0fV+04ekKG+pV76HQmZM3impqDYke0DYRnpmlhRkgQ8Q +tjeYtbTGwBnHi3vG+czwqEZ2J3xCgvK00CyfR3nwokciHeQaxpMh6Nm3KVkPQdPbELx dIj0Lq+wqiBulyHBw06Q8+m3w6XPLa6B41CllNsGHw/AiPpvtLNVPyNHnFugrE7HTLn0 +bRtrBmsNb2WdpmHBTh/Rj0ey3YzM/eaayXerV9BmwaJrdsuTxP5ZgMpEHdnHigx4law Nm8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i0K8HEN0VqXyWez+n9yUZrkoJZgLatRkHeqtV9uSPwY=; b=fKrOr8DCWgBTlqMJDgExhEtcBZQnkA33R2+fv5D10Z34uRDB+wpM1eEMeZgvaGTLwp 4OAIbD0I6Z9YZxEotZ49wySb54+ptYoA95449Hjb9JttvB6n9ctizrjhV7xQP86LWcYj U51RNBcmo8zgZTILTCy8Hx98Pwf4sxykX9YL7PC/aukEc7SgWpRq70sJLPBhno47Ygm/ tjfFNM0QfhLrgJC9AnIvw6f3uSK39zloSLCny/VYNTsjLdTr+Q037mxSWQCtpFu9+SZg tMh1WyWyIZt9cxuUqmg7blXfTR0C8jjujLMRsUKAqD/qrviS7zmnM6P3aoq6A5Sjaw9V o/6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="rDbXVS2/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4si13941895otn.281.2020.01.16.13.35.15; Thu, 16 Jan 2020 13:35:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="rDbXVS2/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393830AbgAPRmc (ORCPT + 99 others); Thu, 16 Jan 2020 12:42:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:59458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393681AbgAPRln (ORCPT ); Thu, 16 Jan 2020 12:41:43 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F170246B5; Thu, 16 Jan 2020 17:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196502; bh=yIJkJxmik4IXSliExkB5nxxRKUuXaE04cSZDwEwRw6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rDbXVS2/0HJ1zQiSm/hu7FxRYeJgDSz6M63tg/2SslcLH7+vJpNd6xonPVsv/641y aQt6ePZA2oRTc8N2RqYT63dumr3WWs8EtUuZzV67ukAwmUgO1V3OFsBl4vxJlQFCNh x7hOnTh88QWSTGZWHNfyXV3PU2DaGUN02EqpqGos= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pan Bian , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 244/251] scsi: bnx2i: fix potential use after free Date: Thu, 16 Jan 2020 12:36:33 -0500 Message-Id: <20200116173641.22137-204-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 29d28f2b8d3736ac61c28ef7e20fda63795b74d9 ] The member hba->pcidev may be used after its reference is dropped. Move the put function to where it is never used to avoid potential use after free issues. Fixes: a77171806515 ("[SCSI] bnx2i: Removed the reference to the netdev->base_addr") Link: https://lore.kernel.org/r/1573043541-19126-1-git-send-email-bianpan2016@163.com Signed-off-by: Pan Bian Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index 133901fd3e35..6d1f8b22bd83 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -915,12 +915,12 @@ void bnx2i_free_hba(struct bnx2i_hba *hba) INIT_LIST_HEAD(&hba->ep_ofld_list); INIT_LIST_HEAD(&hba->ep_active_list); INIT_LIST_HEAD(&hba->ep_destroy_list); - pci_dev_put(hba->pcidev); if (hba->regview) { pci_iounmap(hba->pcidev, hba->regview); hba->regview = NULL; } + pci_dev_put(hba->pcidev); bnx2i_free_mp_bdt(hba); bnx2i_release_free_cid_que(hba); iscsi_host_free(shost); -- 2.20.1