Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@kernel.org>,
        Shakeel Butt <shakeelb@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v2 6/6] mm: kmem: rename (__)memcg_kmem_(un)charge_memcg()
 to __memcg_kmem_(un)charge()
Thread-Topic: [PATCH v2 6/6] mm: kmem: rename
 (__)memcg_kmem_(un)charge_memcg() to __memcg_kmem_(un)charge()
Thread-Index: AQHVzJKbgVUSlNYKkESLg4k9oItO2aftjtoA
Date:   Thu, 16 Jan 2020 17:40:14 +0000
Message-ID: <20200116174010.GA15833@tower.DHCP.thefacebook.com>
References: <20200109202659.752357-1-guro@fb.com>
 <20200109202659.752357-7-guro@fb.com> <20200116173002.GF57074@cmpxchg.org>
In-Reply-To: <20200116173002.GF57074@cmpxchg.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::2:492d]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23ebee7f-c5e9-4568-abdc-08d79aab24d0
x-ms-traffictypediagnostic: BYAPR15MB3254:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR15MB325449ECDB439DC1855A336DBE360@BYAPR15MB3254.namprd15.prod.outlook.com>
x-fb-source: Internal
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 02843AA9E0
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(396003)(136003)(366004)(39860400002)(189003)(199004)(4744005)(52116002)(1076003)(8936002)(8676002)(66946007)(66556008)(86362001)(71200400001)(6506007)(66446008)(64756008)(16526019)(66476007)(54906003)(81156014)(7696005)(5660300002)(2906002)(6916009)(316002)(81166006)(478600001)(9686003)(33656002)(4326008)(186003)(55016002);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB3254;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: /88UTiiESvFryIYrPVbpJcQDj4PrgLQAEWEGoL04DQ4PHDlLQCl7/b+xJ2KB29qNd8KlLCjGtGRRA2op7hcI3Zic/no7+E3gFWNzrZ/k4reS/IchW9zokabaxuEYGJSovGtme8PexGtFjrSQbDz0fdDEk4id7FgI6DiQDnJpzRTwxELKgT8MzZqgYlfqsGcicoggdmE6LuQdCJ5MRd1UhfKOdkHgOhtGDSP4jHPeSyv8XXW4m6p2nqHsugawIDPZzJsJr2/61+IGrQn03ErEUW9+IrOTm/3HLL9M2M+sqNrwvV+c69sGfJqS74cTjjDVHjKXJZIBRP9iMWpXAN9rvJrZyBR8jENyS+GgPl9CCn2xRZammXr6B8B0m7NZM62cByaB0JS2RE86u/xch34FOIxxlmiuuxZ5VNader05ldffjbH6NOHW5izU2zJ0hjKG
Content-Type: text/plain; charset="us-ascii"
Content-ID: <795EB003EDC6FB458C73B493DF0DD550@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 23ebee7f-c5e9-4568-abdc-08d79aab24d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2020 17:40:14.6043
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l299UcLCFgOufrgjtu09PrCq5MfI6152S+8zc4GX+UWKf15iHRRPCvg8i6IczClf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3254
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-01-16_05:2020-01-16,2020-01-16 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0
 spamscore=0 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015
 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0
 adultscore=0 mlxlogscore=393 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-1910280000 definitions=main-2001160142
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 16, 2020 at 12:30:02PM -0500, Johannes Weiner wrote:
> On Thu, Jan 09, 2020 at 12:26:59PM -0800, Roman Gushchin wrote:
> > Drop the _memcg suffix from (__)memcg_kmem_(un)charge functions.
> > It's shorter and more obvious.
> >=20
> > These are the most basic functions which are just (un)charging the
> > given cgroup with the given amount of pages.
> >=20
> > Also fix up the corresponding comments.
> >=20
> > Signed-off-by: Roman Gushchin <guro@fb.com>
>=20
> This looks good to me. I also appreciate the grouping of the functions
> by layer (first charge/uncharge, then charge_page/uncharge_page).
>=20
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Thank you for the review!