Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8267724ybl; Thu, 16 Jan 2020 13:35:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxNkYTjmL0iqgZpaFWT2LVmLaba53I2LnjWZMkwhHjxnrpARhJV5RF2AghRR9dnTda2SdPO X-Received: by 2002:aca:5188:: with SMTP id f130mr982458oib.47.1579210531218; Thu, 16 Jan 2020 13:35:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579210531; cv=none; d=google.com; s=arc-20160816; b=F6Z5leneQTMwVp8K8Ovhl/z77U8f9pT8XEUeMY+hEF6Yht+8bJA6PYiiTXWdxKWn26 RMMT3mUUrqjbVB0VL9zkd/c/7pxZmdLGEE1XRUk+yXVp3N58XNJU3LF7d95pxBBSlzol g000OgUQFXUOKi5tZHFK9fe42Qt78EehEq8QbItyJz/R/jtT6t5+6HPkj2UBhsLgO4Q5 9hYVnjhtsNJw6zLXxs65wpWGpzfN2pZyUsB+tZI6dJ1+11TpEK+yiiJOWW1LlSPaVJ7l qgJHf5GBvH6RCMsr2ElUZ0j05iOI9neHzizKST3AJ2aK/xFy1sdc6pO9fHuVWEDg0MlU +fmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0o3whJGeJhTK/bXAvTis5HquoQ5PzFtcPlbkW6P4a1k=; b=Mj/RHQb2ttrOcPVXU05fb06gAGDJXbmcPGyWFFo9lFBZLMRSItDWS06l+Ml2f1pa/Z xRtWRGUr8rlM88VzjBGK923C/fuPGikRjXpk0ey6eGl5Fe4Qk9HnaTgarDC+x8RO2IqK ymGtrjpG22JmdzwgKVDelaYRt1Mn/xmGrGeRSvxssyw+7g06nHRFjkqzoVhqYhTfILGU hbZv93GokRfQ/f5+sYdRScrqN+L7dfKV63h7Juvud6cVph3lGoq+vdc6IbJ9IzulIb6t 4T1MFWO4iX/921BFTfCTr1gxXcR7R8OFo7Ukd5EL+UN7QPl207zlLjVxlS2AZxPqjK91 8Dfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fe+1XHfv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i78si12462088oib.1.2020.01.16.13.35.19; Thu, 16 Jan 2020 13:35:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fe+1XHfv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405729AbgAPRle (ORCPT + 99 others); Thu, 16 Jan 2020 12:41:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:58086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393674AbgAPRkp (ORCPT ); Thu, 16 Jan 2020 12:40:45 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C99C420684; Thu, 16 Jan 2020 17:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196444; bh=sqN9Ia28wx00eEWZy/Rnbw2Pe3jh79jsaCmiTr1yRgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fe+1XHfvoYKzPge4CU59RyEbdjgA/zw81HBzv/THFfB0swNARKsuAuDS6CfkiRosu oPb+dC6otTDYqWdqAn1vTAYffnnFrsOO9muOIYIeprAbpRNEuLz9TtIZl4CzDWYEIk EovAZujRvOJo4UI44AYbVesQziQPNAZbuNX60eJM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.9 207/251] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of_parse() Date: Thu, 16 Jan 2020 12:35:56 -0500 Message-Id: <20200116173641.22137-167-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 231042181dc9d6122c6faba64e99ccb25f13cc6c ] The "gmac->phy_mode" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling will never be triggered. Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c index 866444b6c82f..11a4a81b0397 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c @@ -203,7 +203,7 @@ static int ipq806x_gmac_of_parse(struct ipq806x_gmac *gmac) struct device *dev = &gmac->pdev->dev; gmac->phy_mode = of_get_phy_mode(dev->of_node); - if (gmac->phy_mode < 0) { + if ((int)gmac->phy_mode < 0) { dev_err(dev, "missing phy mode property\n"); return -EINVAL; } -- 2.20.1