Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8290561ybl; Thu, 16 Jan 2020 14:02:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxM/LBfy7HbsABPcn2qUzWGQt3Ukfyzu7EewCLlJlBWqDrNHFV758YfVufaoTrESDzramF8 X-Received: by 2002:a9d:6f0d:: with SMTP id n13mr3898040otq.165.1579212150306; Thu, 16 Jan 2020 14:02:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579212150; cv=none; d=google.com; s=arc-20160816; b=FJXPU3hEDBRCHtMBNOrbi6yY8UAiibsfGMPJzN6JfVzX1bfgqAxzeofq1iBAWFlonX 2Z9OPj4gad0Yyd+SYi3tl+jw3wQ9WV9XwZzha+HltFx9TsUThuTVmfmECBsMWP4oRn9V 23/afxTVSGENm88kcKfEtKnFKsPubIv8qD3sgg+3n+Gxs1cyPCnDTOAB8pQHjxigkpke dl0DtcYfUNOJHLMlBjGkJaJ8OZ2lizdFYUzAHu/NZLf7P6lpjUNj63Em69wj8A4kHn8J tH7ecvtlm2nvSlD/4AMH2MTCFsO+TpfoEGHIF7Oqd2EENVseECq6jhM/09NZtzU8g/rv venw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7SRGOc3+W0SCERDU+btzGjYs21kRUTIoqrVmC+GWHuM=; b=h9vtQrx6jjr1o18W8TpZXFMa0ICOwEHmjHVUeeRlsXL2C4Vir4UqibDNIhpDJ1vumD N0+016TmCCGJX5YxqjWZJgnGBGYqZ0RTHRK7WgjFTZfIOu7y5C6MP088SjyaKZ+Kuy0U cEVwFbcuJsdys2BkeLW0vLHqxUG/Rrm4xrqPUN2WnOlfoOyB+S+M35O7GENsr37pNNSY UcPo5b6bCcgeMH4vKOtx67740J+F/td0bXO88auZVpbu5V1j9TDhYCCAHpXomcyxq7Yo JCf/pw+5yNv6US3DTw3PXkO2wKvyasJ+7J9l5Wf+oZ5HvpVCT4y/RW+z+BSp4u9J/gyj VXHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vDN7IFdi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si12322300oie.146.2020.01.16.14.02.18; Thu, 16 Jan 2020 14:02:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vDN7IFdi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405449AbgAPRht (ORCPT + 99 others); Thu, 16 Jan 2020 12:37:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:52828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405375AbgAPRha (ORCPT ); Thu, 16 Jan 2020 12:37:30 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15E71246E5; Thu, 16 Jan 2020 17:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196249; bh=xYjH+m2aO9ma/Nyj7HH0ReQJgmMt1kCeRHmxT3MChuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vDN7IFdiJtpi0kxCAYAQRKac9Usa+m+BgmVI/J0MY6cmdPAz2UtssaOKfI28c1M9X h47SjG/LG+j+KxL/FKUBWWSLuo862cFg93Y9Gex3lNAPmxkd8/v8lAVBKLOVDGxhe2 hCLK65XoqLPBK+1f5NCbpSJ8y5CjdCSvHQjSohZs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.9 077/251] regulator: pv88080: Fix array out-of-bounds access Date: Thu, 16 Jan 2020 12:33:46 -0500 Message-Id: <20200116173641.22137-37-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 3c413f594c4f9df40061445667ca11a12bc8ee34 ] Fix off-by-one while iterating current_limits array. The valid index should be 0 ~ n_current_limits -1. Fixes: 99cf3af5e2d5 ("regulator: pv88080: new regulator driver") Signed-off-by: Axel Lin Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/pv88080-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pv88080-regulator.c b/drivers/regulator/pv88080-regulator.c index 954a20eeb26f..a40ecfb77210 100644 --- a/drivers/regulator/pv88080-regulator.c +++ b/drivers/regulator/pv88080-regulator.c @@ -279,7 +279,7 @@ static int pv88080_set_current_limit(struct regulator_dev *rdev, int min, int i; /* search for closest to maximum */ - for (i = info->n_current_limits; i >= 0; i--) { + for (i = info->n_current_limits - 1; i >= 0; i--) { if (min <= info->current_limits[i] && max >= info->current_limits[i]) { return regmap_update_bits(rdev->regmap, -- 2.20.1