Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8330767ybl; Thu, 16 Jan 2020 14:46:26 -0800 (PST) X-Google-Smtp-Source: APXvYqzoazA+r+H2oeqWipL8ZaNZiHx5QVhi4GCfYFLfijymNtEAAb/JFBAIUoEuQDmDjd7QNWZI X-Received: by 2002:a9d:6d81:: with SMTP id x1mr4173106otp.9.1579214786578; Thu, 16 Jan 2020 14:46:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579214786; cv=none; d=google.com; s=arc-20160816; b=y3HUA5GgmTx+oadvJAv/FST7LHk+JPa0Tvlr0MtXSg63vOTb3HCAJJKQGMEFtrFgCe lZM8/Z96cjbQe5i3UFDhvq/WJzv+GMZ1ncT2GKUYbSK7brMvoGpdM94twjMHWHEkKp12 6vOxqZE6dFbnYt5kgJPM1cNFqUF2nUOKBjHuTLPXZyakTl9Jger771WSOPIbg6Mhqusd yYqOpuvCOUO7QB3WFdVt/kv2Fs6a74SU8cLwOe79svmGZ6nyuMI+wunL/kP1RcCsjc5+ CnZW8tIlv+holEPAP23DdOxqA7AJ3FWtF7LzPc1jpLXY/tTSX4+jRMXoVkAV8rUuIs59 m+MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+sAv2RvvGHsFh+/F8UuMZOjkvTcz5NiPoiDcBB8G3Uc=; b=kPwzOIdSC9O/FDbX2AhBSU9IqGR1A2527pOWbVEog8ynoCL/ip9Ckt7v7fXwz6nH9t Ndyc9vq5s6CUiue3lkXAEolZzYHa0JMgpmfQgePfVguSgoiMNUrF67p1ExzYAlmMtitE cuDrTm/6DWy41pBoN6oAQ7sj5Q2HYO5rUCIQ0WXDOMXvcvGEqJH5Vu+U4aQcdUqUZSwo rdzM0lEMURcpjfI9L2r9/AsirsSnj/+NlN24hME8DmA7lGxoBMEaVlKntHpUHR/PBJnG 8xxYLC4lof1Gb2u4VWhqzzNMSucJvHVt5m8Uu2G9qqMRy4MxyJPiZguCVSVfuiVx/Wr+ nHYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hToWdV+K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i15si14318454otk.120.2020.01.16.14.46.15; Thu, 16 Jan 2020 14:46:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hToWdV+K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395034AbgAPSIl (ORCPT + 99 others); Thu, 16 Jan 2020 13:08:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:54604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393232AbgAPRil (ORCPT ); Thu, 16 Jan 2020 12:38:41 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8267E246DD; Thu, 16 Jan 2020 17:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196320; bh=DFY2xJ6oT72ntgufKPgHkk3dp5CRgSUSTNJfVJtkg/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hToWdV+Km+6kDlybUFPYBC3xSS07l+gWxswA851Yg90F7+1rpNqyF6AKFopIfl7Ju c0GbLaK5J0WR9+GOweycNdzgWl0BmEXDhvd1XMGZGCzkRXXBkwlkmpTRuqWFp556Nx I7fC71mf76tOywkQAeRt1MMt9fo9t3T1DBloC6JM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jerome Brunet , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 4.9 124/251] ASoC: fix valid stream condition Date: Thu, 16 Jan 2020 12:34:33 -0500 Message-Id: <20200116173641.22137-84-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jerome Brunet [ Upstream commit 6a7c59c6d9f3b280e81d7a04bbe4e55e90152dce ] A stream may specify a rate range using 'rate_min' and 'rate_max', so a stream may be valid and not specify any rates. However, as stream cannot be valid and not have any channel. Let's use this condition instead to determine if a stream is valid or not. Fixes: cde79035c6cf ("ASoC: Handle multiple codecs with split playback / capture") Signed-off-by: Jerome Brunet Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-pcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index d69559e45872..635b22fa1101 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -48,8 +48,8 @@ static bool snd_soc_dai_stream_valid(struct snd_soc_dai *dai, int stream) else codec_stream = &dai->driver->capture; - /* If the codec specifies any rate at all, it supports the stream. */ - return codec_stream->rates; + /* If the codec specifies any channels at all, it supports the stream */ + return codec_stream->channels_min; } /** -- 2.20.1