Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8362565ybl; Thu, 16 Jan 2020 15:22:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxkPHkVedTfV18/xaxKWl2zHWaESZawQHtOQKg6RFgfFo9a2pNh+zrghf7+oyTgEqTBYI6Q X-Received: by 2002:aca:db41:: with SMTP id s62mr1283872oig.87.1579216951496; Thu, 16 Jan 2020 15:22:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579216951; cv=none; d=google.com; s=arc-20160816; b=LtEA21NNP1wqUOg2NxOdtWL8mEtBU3ScEYo2DS4Wa3JwyxyNOY7GXO/cx3F4D+OK7D IaKcz0MnEs5sOTnEmZ/yHxGhy85cGVml4b/GkR3rlwSB39AXH5bq5t+ReXIGHozmkZCp kIRKyNS6Jmkag4A94aleaS6AqLj2lXh00s9qzyzs/dxhc/1sYRSl9wkR+1Pp6pw3Oz/h oWIGJM95ug08vFh+6E1ixgglQDXpY+V+aG8BeZpKz0wqXYDUFSTuFCG/aVstfV6JVyhw 1vLCuP3fpXZG7jAo866ji6fHVqu4ce+77YFBXScI5HueYhdSJJecDmtENlQrwHYPibbC VMvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Btd/huVfIOnCkjVZoTOczCYO46sqrrg/s9f8wIGUfDw=; b=zBsIpJF1+vYgYMPl3J8ZAPnlG37tyoRudp8Q1jwn78Y3u5oeoJPCHHDJywKVeDGuMN 1CMjUrouwE0/ln1duUh0pS+wnPEY8jiL3baCvjeCgo+0ubGGtFnU4U9uRjFqQD663LlR 0TKTkajcfc0yxOI2juR84mQogwF1z3NEzqGnDsA35hpo2HTqgFEUx5axbOKwvV7aVJv/ HrOcAOHCFqMqDmTnYFakcSyxPqTLpypvOvgks5mweWBpll0WszlyAnY+e/X5ZOx6fVjx tFbWyFJVlcqOM48y60eJs+myZ7ikvbRU8RpEMkuuH9kMHw9CEIoEa033mfLrsuVT4n5H qkTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fY9OI06C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t142si12498053oih.242.2020.01.16.15.22.19; Thu, 16 Jan 2020 15:22:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fY9OI06C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387399AbgAPTPu (ORCPT + 99 others); Thu, 16 Jan 2020 14:15:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:41576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733098AbgAPQzx (ORCPT ); Thu, 16 Jan 2020 11:55:53 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AA70205F4; Thu, 16 Jan 2020 16:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193752; bh=iTZ3/mJbUdvgbPjh50KeuMkSDpA6gvzu10MlVUhBkFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fY9OI06C20zNRd6kpxMKAzgl4ydmIe71Hd05zn80cwe1PczRrN03cFV7bSu8uFlz/ T1SIfPnPYyglFFLxuY47Hq4E3LP9A4eOOPOMrvZRu4102RcMu2rtL0T9lGfrd2Hixl npwFyfOVagYsYciLNZjR/ciXRXDnWZaiBVxFEpLY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maxime Ripard , Dan Carpenter , Giulio Benetti , Sasha Levin , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 041/671] drm/sun4i: hdmi: Fix double flag assignation Date: Thu, 16 Jan 2020 11:44:32 -0500 Message-Id: <20200116165502.8838-41-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165502.8838-1-sashal@kernel.org> References: <20200116165502.8838-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Ripard [ Upstream commit 1e0ff648940e603cab6c52cf3723017d30d78f30 ] The is_double flag is a boolean currently assigned to the value of the d variable, that is either 1 or 2. It means that this is_double variable is always set to true, even though the initial intent was to have it set to true when d is 2. Fix this. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Reported-by: Dan Carpenter Signed-off-by: Maxime Ripard Reviewed-by: Giulio Benetti Link: https://patchwork.freedesktop.org/patch/msgid/20181021163446.29135-2-maxime.ripard@bootlin.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 3ecffa52c814..a74adec6c5dc 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -52,7 +52,7 @@ static unsigned long sun4i_tmds_calc_divider(unsigned long rate, (rate - tmp_rate) < (rate - best_rate)) { best_rate = tmp_rate; best_m = m; - is_double = d; + is_double = (d == 2) ? true : false; } } } -- 2.20.1