Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8364750ybl; Thu, 16 Jan 2020 15:25:04 -0800 (PST) X-Google-Smtp-Source: APXvYqy1vThf4H4VVvpiyISqLDtxIBPAbPjGPAUfiibHhvtjVDO5EA8hnRXoarEY+bYh3Sr7Ofvi X-Received: by 2002:a05:6808:251:: with SMTP id m17mr1323385oie.15.1579217104244; Thu, 16 Jan 2020 15:25:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579217104; cv=none; d=google.com; s=arc-20160816; b=DowXLhsvFfyImvehu35YTeSdRTdRniEyVlKk/vT0NRtGjLp/QzAtA9C8c+y/r1Q3ju bGhqg2xWetm2DQcjPz5IndbIF6+vwuTiDoPtQOuJnLBoTLc8TwhL1gyk0XDnN53JXrjP DggbigU6JI5gkX/4Pov7bIW8gVt2RkP8F+AoohNni69hfWG1+meRaaYoJmZ6n7sa7Q3y PejuxEiZMOfpdhinpQzaHHL6tIjL+P4Parn3YMZlpno1+8d+km7mCsWVL1KujMraXnR8 iO7CKgntYB+A143p62fXUE3rjxLbMdKxUBWiwEHi/br86wRScWtBtFxbdgAUhKMwCl9i efvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=J/6nixoSIoKE6eZ+cJNMdmi8y/6oky8cFSXcKfYMtxQ=; b=C0rg/IPwR0xuUlfT1z8vp9zkwFzXuwrausrUuQNrhUHr7/pzBt9HIB7Er37jKxi+FR DUWkcH1NvBlo8kP5P/6wtb9NbUjlzhZizgx3+9RlhGmzeAHeFNRKR+7mlAzieCd1XWZP +tUHn1nKcFplWM2lTB5xWa0vv806/tYFw2aSONvej2Wn89zv/6x9qCCfypkMZ3CNwT10 Y+8nvLfhU6fjuDFWKmygoQnF2f8Yt2/OSRWm5Z9/tJKtzF/5oM8ADkvWWhP9EP0txVfd bpywnaSutxxOgJqwKVbGAvz0L+qXUlA+d6yYSXMiulYCO5ga37wFclVM8X5smeLEO/fs BzpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=lQeRJkmR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b20si14459990otf.199.2020.01.16.15.24.49; Thu, 16 Jan 2020 15:25:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=lQeRJkmR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731050AbgAPThc (ORCPT + 99 others); Thu, 16 Jan 2020 14:37:32 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:40738 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729285AbgAPThc (ORCPT ); Thu, 16 Jan 2020 14:37:32 -0500 Received: by mail-lj1-f196.google.com with SMTP id u1so23901464ljk.7 for ; Thu, 16 Jan 2020 11:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J/6nixoSIoKE6eZ+cJNMdmi8y/6oky8cFSXcKfYMtxQ=; b=lQeRJkmRDyrHLNcLnxExOdsvsc6kYdTstdedfLJdxBc2Hb3NbgtxdXq880Yfcy82zG +B+Vj80m+NtyaXkPaj1oRCBWHZw+GQgQ30H1LhlD5+Kga/+5lKOt7WrVHgEFRKopB44a RFWPlwiohqMayaO3MO4ek0DoQ9Ff1EfnmeIyaoDhopImoqVNumyuBCo9PDfxM1ouTBsY DWUVkhfv5yaDU08IGVaS+B0+gdsSWikaE2NGLkHrZDFpqeqVJ+l8SQOT1CzlM+6bJ+Ym K8Gxs5sKXmBofKEQrueCfPV/lt1FSA0dU8fbsE/pFEJOEhaTyAqPZHacl3xhe+JttXvx cCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J/6nixoSIoKE6eZ+cJNMdmi8y/6oky8cFSXcKfYMtxQ=; b=Knz+6PAlutt+55+hQYMTf5vfi0PL7SsIq/vEOZl+xq4BR5Ct/VAicoZqZMU4ijzLlk S78uVZsujjYTWNIB1t/ATui346i1oySRd8JMFuEhdKnrOopttD96nrAVLLzVGvzq4jzK usW9lMXZdK/j1lP/yJXYSjyEOepoiMDSnaTgBVIqAxJQpIUjdj3LMrfaTfRZb2SSidnD jJDY84sP/ZzXyfp3bCf9NGlUH+hRFjfYgLca8Yl3yIB4icb3AW5TEIEchuiVAsGgN54g j+i+qScU5c7r0rJ2dd4Tbn2BDVtfJYyJyFHX9yQl3zT3U6Yr45RE1DxCxPQera4ci2Ew xl/g== X-Gm-Message-State: APjAAAUgGj9TDd01/GN87GGNOxZXfddTPNJ0Re0MViWN47h76O8utfrs loh94w/oggOk6nXpCtMUteM1I9ST3UxgqK+RBUw3 X-Received: by 2002:a2e:870b:: with SMTP id m11mr3313585lji.93.1579203450159; Thu, 16 Jan 2020 11:37:30 -0800 (PST) MIME-Version: 1.0 References: <20200113150331.34108-1-yehs2007@zoho.com> In-Reply-To: <20200113150331.34108-1-yehs2007@zoho.com> From: Paul Moore Date: Thu, 16 Jan 2020 14:37:19 -0500 Message-ID: Subject: Re: [PATCH v2] selinux: remove redundant selinux_nlmsg_perm To: Huaisheng Ye Cc: Stephen Smalley , Eric Paris , James Morris , Serge Hallyn , tyu1@lenovo.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, Huaisheng Ye Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 13, 2020 at 10:05 AM Huaisheng Ye wrote: > From: Huaisheng Ye > > selinux_nlmsg_perm is used for only by selinux_netlink_send. Remove > the redundant function to simplify the code. > > Fix a typo by suggestion from Stephen. > > Signed-off-by: Huaisheng Ye > Acked-by: Stephen Smalley > --- > security/selinux/hooks.c | 73 ++++++++++++++++++++++-------------------------- > 1 file changed, 34 insertions(+), 39 deletions(-) Merged into selinux/next, thanks! -- paul moore www.paul-moore.com