Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8364791ybl; Thu, 16 Jan 2020 15:25:07 -0800 (PST) X-Google-Smtp-Source: APXvYqxUkgzhyvNX7W4OA/POefm7JfaqnIWfEPIF2tJIVr0JaSwGkP2mJTNMYvSnD1sx8SKwD1U8 X-Received: by 2002:a9d:6005:: with SMTP id h5mr4331917otj.153.1579217107541; Thu, 16 Jan 2020 15:25:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579217107; cv=none; d=google.com; s=arc-20160816; b=DIp9VCgSL/YyHr5KCd/bQ55QVgkh0IHMhaEr7M8S2rQLeXYEfFnPuu+2ra4SEP3JV6 MMiehleNGcEJd/KkrSYkiVO6XOsl6euCfZHH4eQ603Hv0RBNm5Kw+TgQRD+KkTk0j3zy /1pXmKrj5klQ3C9ARPsN0jnnQwkNz7TWwvGQ+PhaeJn9Myba6ogtzqv5CwR4I3W648um q7hI9nl0asf12GM7JJjDedOSOy4/gqOIfRiqPzVfj26i1uedSeT38RlMaPxImzDSJciV 1p/+XpbB5vmZyw/YeJ4XZMCXTLkqlfPqVu7r9Ok2yXenB4zdCQ8AXFMiI4sXb7EdBSDS Xg1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XYpBIn2xi7ER9BDGUkOZA9lOy9JYb1E+lxLSXL5KsV0=; b=m2iggD5zRj31uTiBtogEx2jPMcsSyoyc9zQEfYni5uJCFeEcaQjF6OIaW33ZVqyP1d 2MUiMOMKnp4PzOmauUTZH/dZWq2QGjVo4P+y/7/nbwe3a3g/+DdxPDFNswVA7ja+xt13 jbNaFFESRQR5RI99w/2GtTnXap6Twh+yhbwYhqDJOhgDy1P9tEZQpgd9chehLxzNwIYj NSdryRiZHNUHuH2EWtm1IaHh9umQIvZWykj4OuhDbeoS4WlyCwRY1NnrUlwgmkY12OV2 f8HxHypRO73NGY7W0HthCU0zlJ43sLvFQAYVJYO7xBp0P6f4qsvIwY0fzWtG97jsyASA sVyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eQNp5/Mx"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8si12100041oic.163.2020.01.16.15.24.55; Thu, 16 Jan 2020 15:25:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eQNp5/Mx"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387688AbgAPVQq (ORCPT + 99 others); Thu, 16 Jan 2020 16:16:46 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40865 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729991AbgAPVQp (ORCPT ); Thu, 16 Jan 2020 16:16:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579209404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XYpBIn2xi7ER9BDGUkOZA9lOy9JYb1E+lxLSXL5KsV0=; b=eQNp5/MxMeVDUeh4PkZsLXJsQ7TnSNyj0KwqowD2wNTYzYksJ91edREQJbtsPtcx7ITa9d GbknWVIDKBcSBvWZwVK6P0OMMVJCSB36YDq1P3wLZxi4m3Mw+1nY6D9uCgyWrDwS/C/5mQ fiXe6gi7Ig3sI5XT9wtiBlmBCm9TmK4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-8SE2qs9WOcOQW2T5IJLV-A-1; Thu, 16 Jan 2020 16:16:41 -0500 X-MC-Unique: 8SE2qs9WOcOQW2T5IJLV-A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E737184CACF; Thu, 16 Jan 2020 21:16:37 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-90.bss.redhat.com [10.20.1.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5142D60C63; Thu, 16 Jan 2020 21:16:35 +0000 (UTC) From: Lyude Paul To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, "Daniel Vetter" , "David Airlie" , "Maarten Lankhorst" , "Rodrigo Vivi" , linux-kernel@vger.kernel.org, "Imre Deak" , "Jani Nikula" , "Ramalingam C" , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , "Chris Wilson" , "Joonas Lahtinen" , "Lee Shawn C" , "Lyude Paul" Subject: [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes Date: Thu, 16 Jan 2020 16:16:07 -0500 Message-Id: <20200116211623.53799-1-lyude@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I recently got a ThinkPad X1 Extreme 2nd Generation for fixing some issues on, and noticed that out of the box the backlight doesn't work. Along the way of fixing that, I found a few issues with how i915 handles DPCD AUX backlight control and fixed them. Now I've got working backlight controls, hooray! Note that this patch series enables DPCD backlight controls by default. This time however, we ignore the backlight type advertised in the VBT (unless it's a custom backlight interface that doesn't use the standard VESA interface over AUX) and just trust the DPCD. Lyude Paul (5): drm/i915: Fix eDP DPCD aux max backlight calculations drm/i915: Assume 100% brightness when not in DPCD control mode drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() drm/i915: Don't use VBT for detecting DPCD backlight controls drm/i915: Auto detect DPCD backlight support by default .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 175 ++++++++++++------ drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 4 files changed, 126 insertions(+), 56 deletions(-) --=20 2.24.1