Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8365945ybl; Thu, 16 Jan 2020 15:26:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyqh96sVlwqjNQpuIG5kxLRCERf3LncULjrpX+2Wi+VQaqpIvaNjWKrZ76koR4Kkuu8uxU9 X-Received: by 2002:a9d:69ce:: with SMTP id v14mr4254157oto.248.1579217191832; Thu, 16 Jan 2020 15:26:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579217191; cv=none; d=google.com; s=arc-20160816; b=SOQJvCCltuDXtjI5KErzOfjHiSyPMxCvKrfGQN+lRsKYwGe5U9D7Vs+CgB+veD/94/ 9BAe3nvEhs9VhDi7FL1sDgaAslpFv8AHnFjZ3qHpBaLuuA7I2SjyVg4avVv5hfvb8Z3s CD5s4Py7cfiwnXwl5ucPS3ZkzRTQMmLxUyey9hJIzDMlVYOrMOiBBZkEy6glGhIQeakF nFlJK4sYMW2WE8BK68wgVlTxw8+AiAQVEPxeOg6py4jwGTRsxuMfnOPqiK6L+4OI+WrU 5O5sk4eHO0fEHQGpCq8r8PI4HEcz3v90Vn3fPD67ct4razCgcwQj7kkc6qGjlkj7v5tZ u7Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=x6sXuUhwD78rNMwCezwf2SJFMuo48cD5mQHoToWvu1I=; b=Q8CWZp4OPnCMf2QXlQ+J+kMLHjtZulnnTXKgRQq7XACyuIVkEhPxxB/haavx73lGDd BC7t2pSzvQWMqebSdAGD9ZwLX1YMTWBJl3iyPYHW1jEqvmS7w+XVVVp/PjqgkpwouQAR XqnPzCDL2IjzSjKMLCB3lw/0/UFtWDJ+eSWRPxwq0P8mCStsLy2VFfGar/iOgUuaHn95 eLCw80K8tlzEUCpvR0xEzNecSrQuDWvCvUVEgUrj4sWqFZ1LCEa09yhm1UY9pi2toSeH z/oQbeiUoVZh2t7VxcY9XApnn7Ez58sYhDTg8p0gGI2t4DL+R4sSuUZYmnMWvnUo3BIs TO7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GtABQGCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si11991594oib.115.2020.01.16.15.26.20; Thu, 16 Jan 2020 15:26:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GtABQGCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389521AbgAPWAR (ORCPT + 99 others); Thu, 16 Jan 2020 17:00:17 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:33338 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730816AbgAPWAR (ORCPT ); Thu, 16 Jan 2020 17:00:17 -0500 Received: by mail-wm1-f68.google.com with SMTP id d139so8116196wmd.0; Thu, 16 Jan 2020 14:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x6sXuUhwD78rNMwCezwf2SJFMuo48cD5mQHoToWvu1I=; b=GtABQGCfpaKRoI5woC8t2sbkj2+IZczrtiwOMqw8JtdlNz9Dg8taQzlJcEcpW9AJv9 6s9jtxT1FMMyPqtMLlcNL8/ETc9x3+ab1TdT7l34kDOaMDR48QdTqzMG0dxL2PsU3zzK xnvi7PYOoDg5gDVT1C60Tv5UcP9gg54Cg7eObhtYMDbnFUT8FYWnzL3A6Ec+xq6sF2C8 BqBj9suGjLSOy9ndfMA22l1CETNnu7f0SLMOc0JQH/T3Achtdi9Wc1ofatLGk0Ws+sgC lx1t76aqqDt3uKy3tnmy8a2U5YSti3KLw/kiCDxyUEzf3f9iYms/ZbCV07Kwen2S0aI0 gtbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x6sXuUhwD78rNMwCezwf2SJFMuo48cD5mQHoToWvu1I=; b=p9wIxr6giRrkEoBeGsmFnI9ySMHSfIr8gWyjitWkMCY8hcNl2yhr6t93Bx9ljF+mfN Qpr8R8QcqoGu++hQG0tGIS/McuJKtcuvnkCLQ7uYdMPzZUe47D7gnnqubrz/T7c2z4Of q2RyQUwN1H8LCjRaJtL6If21G+LQhOeeTRdrvjdcGc5boVoRsF2y3k3EfnuR6ARHJuHo j85qvOoQih0MU55Y0L9k1my9voURBrtRVBqtS+sSrBgaKHo0uFJowKqpr3oYMaAuGK7/ vHwKr2GDB9N5qU6JTJIO7uuif9sAEFF3XtJF8CZmiKwcMMzcqa4Y0Z6VB19WlaecJpqK CkBA== X-Gm-Message-State: APjAAAXU/IL4ekXtsBDYDeIjkNWCuHozPwMmzDY0PaN1W3iebMSP64pg EphBVgrGD9BmdPre5EPFOjc= X-Received: by 2002:a1c:23d7:: with SMTP id j206mr1166731wmj.39.1579212016105; Thu, 16 Jan 2020 14:00:16 -0800 (PST) Received: from localhost.localdomain (ip5f5bee3c.dynamic.kabel-deutschland.de. [95.91.238.60]) by smtp.gmail.com with ESMTPSA id a14sm32418131wrx.81.2020.01.16.14.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 14:00:15 -0800 (PST) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/9] scsi: ufs: Delete two unnecessary functions Date: Thu, 16 Jan 2020 22:59:10 +0100 Message-Id: <20200116215914.16015-6-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200116215914.16015-1-huobean@gmail.com> References: <20200116215914.16015-1-huobean@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bean Huo Delete ufshcd_read_power_desc() and ufshcd_read_device_desc(), directly inline ufshcd_read_desc() into its callers. Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 087fd894a01b..44b7c0a44b8d 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -3146,17 +3146,6 @@ static inline int ufshcd_read_desc(struct ufs_hba *hba, return ufshcd_read_desc_param(hba, desc_id, desc_index, 0, buf, size); } -static inline int ufshcd_read_power_desc(struct ufs_hba *hba, - u8 *buf, - u32 size) -{ - return ufshcd_read_desc(hba, QUERY_DESC_IDN_POWER, 0, buf, size); -} - -static int ufshcd_read_device_desc(struct ufs_hba *hba, u8 *buf, u32 size) -{ - return ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, buf, size); -} /** * struct uc_string_id - unicode string @@ -6493,7 +6482,8 @@ static void ufshcd_init_icc_levels(struct ufs_hba *hba) if (!desc_buf) return; - ret = ufshcd_read_power_desc(hba, desc_buf, buff_len); + ret = ufshcd_read_desc(hba, QUERY_DESC_IDN_POWER, 0, + desc_buf, buff_len); if (ret) { dev_err(hba->dev, "%s: Failed reading power descriptor.len = %d ret = %d", @@ -6599,7 +6589,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba) goto out; } - err = ufshcd_read_device_desc(hba, desc_buf, hba->desc_size.dev_desc); + err = ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, desc_buf, + hba->desc_size.dev_desc); if (err) { dev_err(hba->dev, "%s: Failed reading Device Desc. err = %d\n", __func__, err); -- 2.17.1