Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8378737ybl; Thu, 16 Jan 2020 15:40:57 -0800 (PST) X-Google-Smtp-Source: APXvYqwlOGGLfdK+K3nHwznZDdgpe8b2dH9TfyRyQpufNO7jJ78oWJoZMaCE0V93n7roWaQpHV69 X-Received: by 2002:aca:815:: with SMTP id 21mr1414411oii.52.1579218057102; Thu, 16 Jan 2020 15:40:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579218057; cv=none; d=google.com; s=arc-20160816; b=06QhrZByEdVHG87+Zx7/INoBB1s5S2XJo4Fb8C/3P+wtflSzqq/XV325d+Dsmh5nVd wzIXi+94gQ2E+RiCUi9yutH0logx4ruZOTsw9+pOBHcp4/aOifGTEBrU2Lm3VwgSnZ1z C6jJzU7H/wBYp+SXQNDYp2vy3cvNf5SHgwdhyR1xBig/dKuF7fDIBAfZRMf3oD7yV8g7 x77q9JZb+4b4KtJuxEuB9+lojvsn4iuFyOmMMLrAyVdYTBhycKFY6IvVlcGlEtx4EfKH iTSQszywO1ErrJ1GJKu88c8SwWU1/2OZ/jT1DHwxpC+6Pjz41AE22z/uZwhLGkB9a3xx tWGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aE+93NuCEcI8ub5NAx6h6V7LXS0RibYzEHu+VMHFxhI=; b=X+LjuPV/cKsdcNp6himeDfmMLsAa6O0Av9wVofa1O5DHzEcYmls1cjDXPgfy+nFVsz HsxQLRzuKh9nANEYP3lCoRnzQ2bEOrCRsaxqUdxX2N92bs3Jz3k9QlZUT31zN8HxRCVW 0RyRX14FAvv/BXAmEPuzj5vpEEWRGobpDXsMtNRwjWGKQX16OZKXNMKs1aAE8CrH3sHj F5qs5mFzlMoQj+RZQfW4pubY+JedK0RwxRgywdiQWRXPugHvbPxjWp4wGPy6RbsPJC62 +Wo8M2ROcvynFD6N/lAiAL32IG7hrlAbkmFcsu2yKfwr6OTNCznETvpBwcqkc9cZHIkR QKrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kzihyre7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x16si12884374otp.184.2020.01.16.15.40.45; Thu, 16 Jan 2020 15:40:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kzihyre7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391088AbgAPX2U (ORCPT + 99 others); Thu, 16 Jan 2020 18:28:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:60930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390734AbgAPX2P (ORCPT ); Thu, 16 Jan 2020 18:28:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94D4620684; Thu, 16 Jan 2020 23:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217294; bh=ocAANWlWEdcaXT6VbO9RDlKzdJkJnLOESxnJLG+KFdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzihyre7pjoVDGFiknGoCfTnLMTZ6kPGxfAyUJ8ju3Iu/r4mqfKrXb315iTXfv5Wd gXUsWLhuWakz9QaJG08e0dkAGzKZeA/1+TfyQMBQD/PEXIsiWQI1JXxTdEed2bdCVr njGdeYecaYgfsZ7WDQKu+pW/ps9Sqjq7gi3yhOEY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aaro Koskinen , Peter Ujfalusi , "H. Nikolaus Schaller" , Miquel Raynal Subject: [PATCH 4.19 23/84] mtd: onenand: omap2: Pass correct flags for prep_dma_memcpy Date: Fri, 17 Jan 2020 00:17:57 +0100 Message-Id: <20200116231716.388547311@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231713.087649517@linuxfoundation.org> References: <20200116231713.087649517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Ujfalusi commit 8bcef0d54067077cf9a6cb129022c77559926e8c upstream. The commit converting the driver to DMAengine was missing the flags for the memcpy prepare call. It went unnoticed since the omap-dma driver was ignoring them. Fixes: 3ed6a4d1de2c5 (" mtd: onenand: omap2: Convert to use dmaengine for memcp") Reported-by: Aaro Koskinen Signed-off-by: Peter Ujfalusi Tested-by: H. Nikolaus Schaller Tested-by: Aaro Koskinen Signed-off-by: Miquel Raynal Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/onenand/omap2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/mtd/nand/onenand/omap2.c +++ b/drivers/mtd/nand/onenand/omap2.c @@ -341,7 +341,8 @@ static inline int omap2_onenand_dma_tran struct dma_async_tx_descriptor *tx; dma_cookie_t cookie; - tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count, 0); + tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count, + DMA_CTRL_ACK | DMA_PREP_INTERRUPT); if (!tx) { dev_err(&c->pdev->dev, "Failed to prepare DMA memcpy\n"); return -EIO;