Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8380030ybl; Thu, 16 Jan 2020 15:42:33 -0800 (PST) X-Google-Smtp-Source: APXvYqwJq6lbbzB9zTNeIDkHCFfGWuDdP+Asn2quddp9cAbA2HnqxECjQjToTB0+ylo7NUY6ruC3 X-Received: by 2002:aca:dfd5:: with SMTP id w204mr1383610oig.95.1579218153206; Thu, 16 Jan 2020 15:42:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579218153; cv=none; d=google.com; s=arc-20160816; b=puCd/bAT6emkWXi3NDFJ6Se5E/5X1sx9FjZrClPcQG/fpAr/5sx7UOHUBkX2HyXBUY mwzJrGeYXbL98j6iqWE7uXTTg08lNHZKopQ1LdtEqPsiTnyfe2IqkzjjwUXhykHU9djK JepTxSD7KxEbEQSYBh06f1h4BEF3xjJjw8tTLcuSMZcOmYVz0KaKyTgiDOxJIgdPTs8m 5CL5CU739Mj2SK3Pbq6QG9pvt5r7m8uF32wWgXPiSBm9FWuYWh0+DpEzuA7zRkG1w+Z6 QqZhIkORXSQVwaXJDkx0ByMb3J2CJHdzHtfR8BgQXHR8vm2YH27XH05TnCv62ay7YGal ylZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XdVmCwBwt//oBCkhqjb8tTmVc8IASboW33NxVb/IAfY=; b=N08TyxaMgv4M2gVHAl1XROId+1W5RfgS9/n5zh4SO+NcWCNjOnAOJyYpks1uJupUm+ PQdjT6+RUB3pzT+ilphKWmT5N0AiyTreWAnviSGMGCCznM0NszL7T81iNOeLcNzQSgSR YaRnoTkcYNqOgHG4+BMpiaIuLwhEmpGAv3yMJCtcL3H5ipXFOVMk/vuQMBrahUmU0w3Q H47gle42vNAAFG7uwazT5UBs/6YUdGtlZXxpfn116vvWtXKZqckO+QSw/SPUycaZKkAi ZCpyp0FFchQZzSoZmSlEmbEp4a5JS0PLoCCq+XCaWfVYO0XG6oylgnaPH7zy/kJFaGhB 7gLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=YPQzpgi+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si12370555oig.88.2020.01.16.15.42.21; Thu, 16 Jan 2020 15:42:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=YPQzpgi+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391438AbgAPXj4 (ORCPT + 99 others); Thu, 16 Jan 2020 18:39:56 -0500 Received: from mail.skyhub.de ([5.9.137.197]:36242 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391259AbgAPXjx (ORCPT ); Thu, 16 Jan 2020 18:39:53 -0500 Received: from zn.tnic (p200300EC2F0B23005181490C10C27842.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:2300:5181:490c:10c2:7842]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 604831EC0391; Fri, 17 Jan 2020 00:39:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1579217991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XdVmCwBwt//oBCkhqjb8tTmVc8IASboW33NxVb/IAfY=; b=YPQzpgi+jN4kZUdorP3ZJjH+er8RY33Mgz3mEO1/YW2ZWPSDNgpTJlvsWjrCMAitTl9XT/ S0Sq0petU47LCGnEwBKNo3nt10UVJmhSlpFpqCG/VG6kxtes4xbGlY6i3y5+6I8hMtx03k 7U+lqdV/g+LomdBjPT+bN37wjTKpVAY= Date: Fri, 17 Jan 2020 00:39:39 +0100 From: Borislav Petkov To: Shiping Ji Cc: James Morse , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, LKML , linux-edac@vger.kernel.org, Mauro Carvalho Chehab , sashal@kernel.org, hangl@microsoft.com, Lei Wang , ruizhao@microsoft.com, shji@microsoft.com, Scott Branden , Yuqing Shen , ray.jui@broadcom.com, wangglei@gmail.com Subject: Re: [PATCH v9 1/2] dt-bindings: edac: arm-dmc520.txt Message-ID: <20200116233939.GI27148@zn.tnic> References: <4fbf026a-4878-cd65-55f7-7d992782b331@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4fbf026a-4878-cd65-55f7-7d992782b331@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 06:32:27AM -0800, Shiping Ji wrote: > This is the device tree bindings for new EDAC driver dmc520_edac.c. > > Signed-off-by: Shiping Ji > Signed-off-by: Lei Wang > Reviewed-by: James Morse So for this patch, v2 had Rui Zhao as an author: https://lkml.kernel.org/r/BN7PR08MB5572B3388B2D7DC8F6C7F285AE4C0@BN7PR08MB5572.namprd08.prod.outlook.com v3 got Lei as an author: https://lkml.kernel.org/r/CY1PR0401MB1244062C1738B09D6100F202860A0@CY1PR0401MB1244.namprd04.prod.outlook.com and now it is you. So when you send next time, think about who's going to be the author. > + line numbers. The valid interrupt names are the followings: WARNING: 'followings' may be misspelled - perhaps 'following'? #51: FILE: Documentation/devicetree/bindings/edac/arm-dmc520.txt:10: + line numbers. The valid interrupt names are the followings: Please integrate scripts/checkpatch.pl into your patch creation workflow. Some of the warnings/errors *actually* make sense. Also, this patch throws this other checkpatch warning: WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst but since Rob reviewed it, I'm going to assume checkpatch is wrong here. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette