Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8394060ybl; Thu, 16 Jan 2020 16:01:00 -0800 (PST) X-Google-Smtp-Source: APXvYqxYv/1G9LMpyczJWm5stBqtRz+HmdAZ4KmCDF+mK4RpoGNck7Z4mAx5xSrwMoY6UWDGjWNz X-Received: by 2002:aca:4183:: with SMTP id o125mr1310057oia.125.1579219260732; Thu, 16 Jan 2020 16:01:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579219260; cv=none; d=google.com; s=arc-20160816; b=I5WiipBPdjWbRbvlG7uT9aavKnm7gD6PwOJ6mDVKHG35JSr2x44oFvMtKKISRm4Fb8 suiOB6PbTURb3rTe0FRiCvSH8GvxruwY5c5DL6BeJSHTw66GEF3iEs7vWr07lVI1knhA IV3OLLRYG8GqKXaEpQjEzbO6Fscry3DJBT3ZY0eJCKrojj2mMVfpOUYJxJPfS3fsxkSr Ey73H3OUvV9sXUBUolhbzl0fvcVVn7Dc2X6a1cJwjeya9hyU6xPCe7Vwu1rjhiXgzXB2 abZbF+f1FsYRjvLl9Xm/PYUHF18UuIarZYyW+LXLe3Mr5QKPVLBGwj76YeQv0EoyDsFH qImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tM1p12/sZvemqqrVhJ1eXiXTLSAfd9M0W+chMuIuaZA=; b=BlFUAACSdz0JHEUc6Hs6zDWtaDz6bsv26H14U9SvT2pGru9zimXWK/6le6VhAFSI3l AjTDhygD6vJ5qCrCHR0pG6O/RCEXWrHt47OZaB1ohOkQB+AAypN2uR05IQXbnyqDfoom gplbqLIYNtqbLARPNWyyBP3wCXcXTAgchSaR+kqtBPTqGTKtMvIgQkPdVgMZ/tUIQs4q 9TUI5Atz04bQx9iUfbJZEa077sITC0woUZU98n8jvqAeM671FItM7ueqp63M4ItyUT2x P18I8ylPsC8FbmUOBZGm7r23288hs8vjPoIeJtAuXoC2+cyXMwmzkJj0vB3PByumM64b zSUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uSA1/16J"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si15164842otj.32.2020.01.16.16.00.48; Thu, 16 Jan 2020 16:01:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uSA1/16J"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395406AbgAPSS3 (ORCPT + 99 others); Thu, 16 Jan 2020 13:18:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:33596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387827AbgAPSS1 (ORCPT ); Thu, 16 Jan 2020 13:18:27 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD97820684; Thu, 16 Jan 2020 18:18:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579198706; bh=eK+zgsqPWz6GAYkJtti8rLXXAgfol0Ms7k1eGuEjvcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uSA1/16Jv5t+QkTG5DUYDIw5GCOnYY7mMdMEHjQJg4sRtJx0p92p7BGyiz1r3y+zt HIA5X6uhHXR8fQZhMAgOktn72OxXqWdijpihtIWgO3rxYSaNPqu/WwZgGkRoZGgc3f iezAkiFdQPopG1zeb3Cek072wQSLs3i8/5I2lSlQ= Date: Thu, 16 Jan 2020 18:18:20 +0000 From: Will Deacon To: Sami Tolvanen Cc: Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Subject: Re: [PATCH v6 12/15] arm64: vdso: disable Shadow Call Stack Message-ID: <20200116181820.GB22420@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20191206221351.38241-1-samitolvanen@google.com> <20191206221351.38241-13-samitolvanen@google.com> <20200116174648.GE21396@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 10:14:24AM -0800, Sami Tolvanen wrote: > On Thu, Jan 16, 2020 at 9:46 AM Will Deacon wrote: > > Should we be removing -ffixed-x18 too, or does that not propagate here > > anyway? > > No, we shouldn't touch -ffixed-x18 here. The vDSO is always built with > x18 reserved since commit 98cd3c3f83fbb ("arm64: vdso: Build vDSO with > -ffixed-x18"). Thanks, in which case: Acked-by: Will Deacon Will