Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8417734ybl; Thu, 16 Jan 2020 16:29:05 -0800 (PST) X-Google-Smtp-Source: APXvYqyI4MGZHrxZ06b7x+yd/tUGcr/F5d1aW3M6TjRnt5ifwNR23djFVPnk4/Yw+iSPwsiQ3ZiN X-Received: by 2002:a05:6830:160c:: with SMTP id g12mr4207992otr.82.1579220944954; Thu, 16 Jan 2020 16:29:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579220944; cv=none; d=google.com; s=arc-20160816; b=llo0IVvj3bqR1Dd0y7l3c2IuIVLlgHhP75sl1+ENqvtwMR8+PjhIC7pRUGxfkl/IPM +Si/LVU7lZdu2uLjFcx2Qbj2K+t/S3nvCbYjq+WftDfIcvhDJqe3Nuc32M4MhuFHqDEp NB9uza3pjkbXyEBUv91yJAynKKfN2S818Gmhae3MXXQ8/5a19hjOa7NQFExtmvl1WpiN 5ny6e5CYyS+Kw5JvB8PLDUofewRDS6gu0KqYBTw+fejF3S36MIINaJU3Im5beFbmPBsP jYRARjPpK9JGImsrf3iDQ0GRl0wr7AI5sPIVBH8W/AWGbKNEVhhn4JQ3R712LTgwk+U1 Ig/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+MZN3U4cPQi0DRPW2v7P00zlMZEm4a8jPXZhxYDPzWo=; b=J8sxWlhxHO+blGYcT9RqY9dLjB3RP4s0twK439JD6aJJR9sFyEBxpnQhhhNJHvsIXF 7t/gTSoiNGk4zlBaroVpMny+ZUqf6xLqWovymviVRHMB9nXpRDm7a341xjr69zx/jrog hFJ8fwRZp/liBaDsoMF7JkkBnK26Dn+nX5k0PbhAMs1pGrkXaHb3Z72i81XcqWXRHgDn FH2Ii5tId6sGfFy2u9OUvv05eVjY3zPsRMqOD9wgqpmToZ/ltWJg2uhIG8aHkqmyojVF 830vLLgLf741ssEwUau1GuUTTm2hSGqcykSu7VGOsTMraaldN9ZKKPWEuAJXQUD2xp+A 5sgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h+QJNazT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si14469632otq.68.2020.01.16.16.28.53; Thu, 16 Jan 2020 16:29:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h+QJNazT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390619AbgAPXUW (ORCPT + 99 others); Thu, 16 Jan 2020 18:20:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:46664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390589AbgAPXUP (ORCPT ); Thu, 16 Jan 2020 18:20:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02DD820684; Thu, 16 Jan 2020 23:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579216814; bh=fXiYfFCIwIIUg6LPoG3LFBYLLvM/DDDTgYBvUbxygTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h+QJNazTMIgaoe2QkzxPr5PChRly6QszQhfLlK121+V3uODWH5vk1Ft2xEzsc+7t7 Qq6L7FodPY6uDbQhw2LektYN/JNR5bL5fUGeqV1WcqH92NSwlpiM5C9LYBtO5UC2un Y6Rv4dIKBd6SwTW3gg6r/u/mmSjmKKBcq9mnGuUY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Olivier Moysan , Mark Brown Subject: [PATCH 5.4 013/203] ASoC: stm32: spdifrx: fix input pin state management Date: Fri, 17 Jan 2020 00:15:30 +0100 Message-Id: <20200116231745.999662191@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231745.218684830@linuxfoundation.org> References: <20200116231745.218684830@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olivier Moysan commit 3b7658679d88b5628939f9bdc8e613f79cd821f9 upstream. Changing input state in iec capture control is not safe, as the pin state may be changed concurrently by ASoC framework. Remove pin state handling in iec capture control. Note: This introduces a restriction on capture control, when pin sleep state is defined in device tree. In this case channel status can be captured only when an audio stream capture is active. Fixes: f68c2a682d44 ("ASoC: stm32: spdifrx: add power management") Signed-off-by: Olivier Moysan Link: https://lore.kernel.org/r/20191204154333.7152-4-olivier.moysan@st.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/stm/stm32_spdifrx.c | 4 ---- 1 file changed, 4 deletions(-) --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include @@ -482,8 +481,6 @@ static int stm32_spdifrx_get_ctrl_data(s memset(spdifrx->cs, 0, SPDIFRX_CS_BYTES_NB); memset(spdifrx->ub, 0, SPDIFRX_UB_BYTES_NB); - pinctrl_pm_select_default_state(&spdifrx->pdev->dev); - ret = stm32_spdifrx_dma_ctrl_start(spdifrx); if (ret < 0) return ret; @@ -515,7 +512,6 @@ static int stm32_spdifrx_get_ctrl_data(s end: clk_disable_unprepare(spdifrx->kclk); - pinctrl_pm_select_sleep_state(&spdifrx->pdev->dev); return ret; }