Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1579173451-2439-1-git-send-email-alan.maguire@oracle.com>
In-Reply-To: <1579173451-2439-1-git-send-email-alan.maguire@oracle.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Thu, 16 Jan 2020 15:27:56 -0800
Message-ID: <CAFd5g47_yrZEHvCHUpc-b-hpMzXzJmaXxevcwpVHhs=2BFR+Bg@mail.gmail.com>
Subject: Re: [PATCH] software node: property entry kunit tests must depend on KUNIT=y
To:     Alan Maguire <alan.maguire@oracle.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Randy Dunlap <rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 16, 2020 at 3:19 AM Alan Maguire <alan.maguire@oracle.com> wrote:
>
> property entry kunit tests are built if CONFIG_KUNIT_DRIVER_PE_TEST
> (a boolean) is 'y'; it in turn depends on CONFIG_KUNIT.  However to
> ensure clean merge with linux-next, where CONFIG_KUNIT is tristate,
> we need to explicitly specify KUNIT=y as a dependency, otherwise
> allmodconfig builds will build kunit as a module and fail to build
> the property entry tests.  Later CONFIG_KUNIT_DRIVER_PE_TEST can
> be converted to tristate.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

Thanks!