Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8507484ybl; Thu, 16 Jan 2020 18:21:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzTmFBE54Y/I8/+6OTIp8r/UN+KFZvzRh6u4tknMxMRbH6M96N2ytDCVyWEhUJRAQ3/jo/I X-Received: by 2002:a05:6830:4d5:: with SMTP id s21mr4432050otd.294.1579227703358; Thu, 16 Jan 2020 18:21:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579227703; cv=none; d=google.com; s=arc-20160816; b=PlSuCjEab5SmXCBqeH7Md9S3LXPiLzKiPIEecITME5Uo2rumYawOpMN5mBYdmKvNTe emwrb4G7pK2xBaZRdCCzZ1Rs3RVIJjwvpyi6VYegqeDlCapoaJMLXRWPhxKNPWweZOin s4NOhYFXnMRZiBzix8NzB7FZcCM2JYGF0J6c5+VZH+AGvJ6Cgwlc9Zg3oXJ+maOhUJ+7 xDQzuQXV0Mo8u4scdnrGWHqRP+UKReeRPvRIEc/q3F0VJ2UTF89dRWW90vjojYYZpjBW gaJUX3NCDvcy2VD4VsYwjFxU1S7VbXKMNF9SiKmXlzh/Ulxrpabbd6AFZe/xKkazC4gW odlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jR7Vvytt3SxHEhN+S6Y4bBiYdWxnc6xaCXqGBuGT22E=; b=Pz+2PbcVRi1LouTbLcT/E96a4gtJl2wiM/mVw6g+wfbzDGVktttAsb47F/O5Cy7wnz UCykQSmEcnvrU54I9Zg8rZtsH3YCUqGnCAieEIOiJxorWPgwCw5qNQtpP+jf9w34ceao +ENWHKkvzlMFcEVWtBEKH33DExCowr8sh4Rmengx8Bx0m/vmXxy50T1JMLXHQl4xsfth 2bviTbyw2I7p8lTiuHlaeZQhCrF1UbeVU+XPR1ZY/Gte5FeSxvPDEXboNfZtDXO0PCKZ UgF4E18uZQEzJ6peu3WrxW+0nqpU7RB4/CozSYwBV3YJL9q0L26Bx/x9czMXnhD5xK8u /gTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H+hQgsWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si13022028otn.108.2020.01.16.18.21.31; Thu, 16 Jan 2020 18:21:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H+hQgsWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733190AbgAPX0v (ORCPT + 99 others); Thu, 16 Jan 2020 18:26:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:56854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729813AbgAPX0X (ORCPT ); Thu, 16 Jan 2020 18:26:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8D102072B; Thu, 16 Jan 2020 23:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217183; bh=bZEy0wfqUW4qgDCnKRR5qhgh4FTE7JLaUDFBxS9Am/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H+hQgsWpu+NFQDhunRrcuVyCq0TlW3sOE66ubP188Jk+IqdCY6qIDvRBGZw1uRkI7 n956K6FyNpNaKtbLZptNmtoZHOXcga7KHYr/Jm5jRu1QJZBkQOvOCBthy3Aw03GtG5 Q8zx3uywZ3MP+RkaIF0ZpmSUXei+tU7gKqKHi8Ec= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johnson Chen , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 181/203] gpio: mpc8xxx: Add platform device to gpiochip->parent Date: Fri, 17 Jan 2020 00:18:18 +0100 Message-Id: <20200116231800.216930758@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231745.218684830@linuxfoundation.org> References: <20200116231745.218684830@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johnson CH Chen (陳昭勳) [ Upstream commit 322f6a3182d42df18059a89c53b09d33919f755e ] Dear Linus Walleij, In old kernels, some APIs still try to use parent->of_node from struct gpio_chip, and it could be resulted in kernel panic because parent is NULL. Adding platform device to gpiochip->parent can fix this problem. Signed-off-by: Johnson Chen Link: https://patchwork.kernel.org/patch/11234609 Link: https://lore.kernel.org/r/HK0PR01MB3521489269F76467DFD7843FFA450@HK0PR01MB3521.apcprd01.prod.exchangelabs.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/gpio/gpio-mpc8xxx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index a031cbcdf6ef..d72a3a5507b0 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -346,6 +346,7 @@ static int mpc8xxx_probe(struct platform_device *pdev) return -ENOMEM; gc = &mpc8xxx_gc->gc; + gc->parent = &pdev->dev; if (of_property_read_bool(np, "little-endian")) { ret = bgpio_init(gc, &pdev->dev, 4, -- 2.20.1