Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8519364ybl; Thu, 16 Jan 2020 18:39:02 -0800 (PST) X-Google-Smtp-Source: APXvYqzgq6BX52tu8l7+2y1RU+lL3jzkg2PefGtrGKOM54e7hBuzjFot+Y8fLzO/NAXdRV5pX4Np X-Received: by 2002:aca:2118:: with SMTP id 24mr1856181oiz.28.1579228742408; Thu, 16 Jan 2020 18:39:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579228742; cv=none; d=google.com; s=arc-20160816; b=xy8IlHylL+taD9G/LwZTW+hy7n7JVcwA/Q8kvu5sO95EQESzFioWRQayjSttSnolHr i3VINQgxfVscsmuuZjUKvCrjjEWNyQ3voWgtRj5hCndymaDXGzvP85UAec8Y0ikJf31n xdVbmb6hsvoVyvHhBgeumm4gvbLjNcidvcJMxzh6wd/CF0zmtIJhCF7wArtVpp6ft269 XiML+NneU8bqCnxWSjfQ4UkGJgS0VD9GK8zldnWfrybbQT92t136n47zcmiTo4WSVrLW ABHJBqTb1U4Q+k7dduQ4EKFw03aQMhNYOo8tuYaMSFfY0N6F+HiunDUWead8Jg0oJxjr HoHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=InEAvFU/Qb+9XggojMKquL57Dy+voo3DNj5dSKkiuHs=; b=nU5/DS4mG3JpTU/lnuD6ZXoLIKlYbKmD3pxI71k+lv88j6XnGq9aMWLv1y1+tc/3Rv SBQtLiiyTxr0ngE+9ZtiPqO/8RPyIdm7GxByTu0sRXqnvUdT36bDf+YdS7GIfU0xUG4h uD1fyw/enoBteJbftze19N1Lqn/rzq0kYKpMvGqbaxU0tE++qtNa07C6M83NMQZ9nhtP m0YFnYbs9yBtZ79mBVB9uDlLySJW1k381SsKY2wTGRGiN/gGdhsNg0caUFEr2aLkXKpi yX3/75a6xZ+vNRlrj1RB3hZeb8sGlxCr3WKBGSLsNu0whiPerh0KkHdoKVI0k8JpRGVl Nfmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CXx6Z2jT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g138si13543338oib.190.2020.01.16.18.38.50; Thu, 16 Jan 2020 18:39:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CXx6Z2jT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403870AbgAPXaX (ORCPT + 99 others); Thu, 16 Jan 2020 18:30:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:36836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403798AbgAPXaN (ORCPT ); Thu, 16 Jan 2020 18:30:13 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5819F2072E; Thu, 16 Jan 2020 23:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217412; bh=5Yo15wUtY4GrEG5p7ZLwqs+m6oyTVZUgg2cKeRyUZ5s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CXx6Z2jTZJTmRPVi6E+WU3u+aII31Vrug0rtH5bRXj52gyPkByD+hNIHaNcZSFzW9 CvuNxVE5w4T9d8TNk7FVi3xIJQvCuk0u3yRNk2UA6vIbvJt80M4X9GeGUS7/H6jYPU 5PMR2OtCeRt3tJyRa8Hd1i6gqy8xyJvEuXT78Mx4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johnson Chen , Linus Walleij , Sasha Levin Subject: [PATCH 4.19 73/84] gpio: mpc8xxx: Add platform device to gpiochip->parent Date: Fri, 17 Jan 2020 00:18:47 +0100 Message-Id: <20200116231722.139540483@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231713.087649517@linuxfoundation.org> References: <20200116231713.087649517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johnson CH Chen (陳昭勳) [ Upstream commit 322f6a3182d42df18059a89c53b09d33919f755e ] Dear Linus Walleij, In old kernels, some APIs still try to use parent->of_node from struct gpio_chip, and it could be resulted in kernel panic because parent is NULL. Adding platform device to gpiochip->parent can fix this problem. Signed-off-by: Johnson Chen Link: https://patchwork.kernel.org/patch/11234609 Link: https://lore.kernel.org/r/HK0PR01MB3521489269F76467DFD7843FFA450@HK0PR01MB3521.apcprd01.prod.exchangelabs.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/gpio/gpio-mpc8xxx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index 3f10f9599f2c..1899d172590b 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -317,6 +317,7 @@ static int mpc8xxx_probe(struct platform_device *pdev) return -ENOMEM; gc = &mpc8xxx_gc->gc; + gc->parent = &pdev->dev; if (of_property_read_bool(np, "little-endian")) { ret = bgpio_init(gc, &pdev->dev, 4, -- 2.20.1