Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8554164ybl; Thu, 16 Jan 2020 19:27:42 -0800 (PST) X-Google-Smtp-Source: APXvYqwmj2NJLHik+Vnswf+nEUQaWnDdeifWkXvBpghGltj/duFiWLGmWVgvOo8V9dG7LZrW7Zyu X-Received: by 2002:a05:6808:24e:: with SMTP id m14mr1985382oie.168.1579231662036; Thu, 16 Jan 2020 19:27:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579231662; cv=none; d=google.com; s=arc-20160816; b=u36PhFWCOHFyDhODXzZ11L+bwclJoRGvIU6ryaJnxEKeP9iyi4z8PdRAwvQ8YnpLtZ XmNlqq29JUtZ03PwAl273I90cM62w+USRGVx8o1ofJaKFnon6WpNXZju9nBcCSx2CMhl 2t9S9Yq3prNqQL5keUZcyoykyI9skdg0NBviMDqLMn+iPlq0fQYjXRn8MRLPbkEzPDpx RhQiZOtOB6QqY59GcWet7rk7MgDhyouHpSQrd/bUScI1J5C+lknqrJ7axcRF1tSLLdki 7WLZQTZLiXBgPYs0XnbQZld9YB2iUTkgw8TMUl/8qQ3dOS1f54hkXj9iPHMKwIrlL3LM lDcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KfD6S1nyDF/HkWClfN4C7W8x7jAUAeQ9Q+0Vqo2GXd4=; b=HKgKGZU8cRS6cK/fxZCr+fmAh0pD0/Qi0gdDtTXmOhWKtGa2AuOgNUfQktoWeErLQU P++t+9/ZlUcb+G9yjOgqJH56GppNb9Zsgq2h5SX/XH/OLS5+3f/jkhYpI6O4TgeV6zVz gjz9NhPD8cjAEd/A6mqi4UN+hHrmcDR/on5SLinLzIB7LKdiwvdCQrWKh98TxCpThrqY EjqXaCIeqJfFLKvoDGTXMZ3NGEsPTkpLAjViaHSgYpK8kueTMfPzropFX7p+1dnf1v6o XbKxtTeEo4+PchJE8bRKauKjcLQ6B2AisNsJEStq/3Vz5U43ozR/eZK0cgeeazgmakTy SrIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mHhD5IO2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si12443370oij.125.2020.01.16.19.27.30; Thu, 16 Jan 2020 19:27:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mHhD5IO2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404017AbgAPXgJ (ORCPT + 99 others); Thu, 16 Jan 2020 18:36:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:40588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391534AbgAPXbu (ORCPT ); Thu, 16 Jan 2020 18:31:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FF63206D9; Thu, 16 Jan 2020 23:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217509; bh=hkDV0F8DLyWObmZCImCKkV2o6hcgmEmc5ef/rDnXpIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mHhD5IO2Xuis3yl/t3SkluJs/BnUTCKtbZIcCMAHDasZqv54bxv0QBn6EdyZL1QCg +SxTuhx8rWH+bdZkIAZUT0rzzHjLyklDOxWSKjtFrMyOq7ERE4x9vfpkQEcQA3mM6t w2F4h0UCP8ctSp8QjyAamh+pVwu12VqbU82HI5CA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sanjay Konduri , Sushant Kumar Mishra , Kalle Valo , Ben Hutchings Subject: [PATCH 4.14 06/71] rsi: add fix for crash during assertions Date: Fri, 17 Jan 2020 00:18:04 +0100 Message-Id: <20200116231710.324691968@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231709.377772748@linuxfoundation.org> References: <20200116231709.377772748@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sanjay Konduri commit abd39c6ded9db53aa44c2540092bdd5fb6590fa8 upstream. Observed crash in some scenarios when assertion has occurred, this is because hw structure is freed and is tried to get accessed in some functions where null check is already present. So, avoided the crash by making the hw to NULL after freeing. Signed-off-by: Sanjay Konduri Signed-off-by: Sushant Kumar Mishra Signed-off-by: Kalle Valo Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c @@ -218,6 +218,7 @@ void rsi_mac80211_detach(struct rsi_hw * ieee80211_stop_queues(hw); ieee80211_unregister_hw(hw); ieee80211_free_hw(hw); + adapter->hw = NULL; } for (band = 0; band < NUM_NL80211_BANDS; band++) {