Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 Jan 2020 17:26:33 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Moshe Shemesh <moshe@mellanox.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next RFC 3/3] net/mlx5: Add FW upgrade reset support
Message-ID: <20200116172633.5d873c17@cakuba.hsd1.ca.comcast.net>
In-Reply-To: <2f7a4d81-6ed9-7c93-1562-1df4dc7f9578@mellanox.com>
References: <1579017328-19643-1-git-send-email-moshe@mellanox.com>
        <1579017328-19643-4-git-send-email-moshe@mellanox.com>
        <20200115070145.3db10fe4@cakuba.hsd1.ca.comcast.net>
        <2f7a4d81-6ed9-7c93-1562-1df4dc7f9578@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 16 Jan 2020 14:52:35 +0000, Moshe Shemesh wrote:
> > If multiple devices under one bridge are a real concern (or otherwise
> > interdependencies) would it make sense to mark the devices as "reload
> > pending" and perform the reloads once all devices in the group has this
> > mark set?  
> 
> All mlx5 current devices support PCI - Express only.
> 
> PCI-Express device should have its own PCI-Express bridge, it is 1x1 
> connection.
> 
> So the check here is just to verify, all functions found under the 
> bridge are expected to be the same device functions (PFs and VFs).

Ah, good, I couldn't confirm that PCIe fact with google fast enough :)
The check sounds good then, with perhaps a small suggestion to add 
a helper in PCIe core if it's already done by two drivers? Can be as 
a follow up..