Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8576899ybl; Thu, 16 Jan 2020 20:02:30 -0800 (PST) X-Google-Smtp-Source: APXvYqy/kGYpkj1mRHg7hH5gNiuDHiUelCbXBKd65/S59+dXQ79fEnn42IhiIxUxEizWcSQVCNu/ X-Received: by 2002:a05:6808:486:: with SMTP id z6mr2035917oid.117.1579233750191; Thu, 16 Jan 2020 20:02:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579233750; cv=none; d=google.com; s=arc-20160816; b=afNYrZhmK1ez2S5TbVng22RzgY9rZCHn13zHMGa559+pKrFVi8CwkXliSwB8CzS/j4 M8lwTulUpzAJp48SBdsGaQPt5Dh5MS31xxCbiSng5Yq3KI/6abmyT9z41ocXrZZHERmw mJoBvIGDTsasrLHg6hNS+WwHdvcc/L1h89BC/somv2MocDfyiKL4DpphzUxDN/RPS6Kk 5RffOub3FFjmP4ZYauQEGW1NG6MV1x+2iVLotASmOx5jH7WxJaisLlVpYxP1E2HW6oDW 4Q7OiVwBaPUPR6WhZOvabe1yxPsOFzgeF+PhIriAAfThOxtxl4+n1j4K5wmBxv9fZhfD s1/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=z+YdJeFqFDZRiS6UDwTkhXHC91WQ1PZ11Rxt5I2e+FU=; b=EmU86Cop4cCTNdk+rYio6Ku5gjJ59S4iWCkzbyVsW+T8fCXwBh7SFxncwvmeqIttSa MSNsHRuEfUJlUslXCuF2uhPo7/I4jJ/Wu9dzfGtAhTtJYIbOiC/3lJZd3XAzEB/H8EBd dDWMjMj+5NiGHcVOwX2GZSkDaWsz4+TA/ui+6RlnADeRB7zpxONOgQBAzi2SUVImTMiX 7tEVQGmwnzrArS+1ZRSwaHCXJ6/eGf0Mvf4MjgzuZnFf6B9YUB/HFhX4QM+0zdEyE9x8 1vYA8TpF4r8EIdl6MN4XFaxv+8ClEGgK+dq2hOKlgll4hSn+5UGOothVYRvJPsVhIZln K/Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=OME1BEPm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g126si13475796oib.105.2020.01.16.20.02.11; Thu, 16 Jan 2020 20:02:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=OME1BEPm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389142AbgAQC76 (ORCPT + 99 others); Thu, 16 Jan 2020 21:59:58 -0500 Received: from mail-pg1-f180.google.com ([209.85.215.180]:45604 "EHLO mail-pg1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389121AbgAQC76 (ORCPT ); Thu, 16 Jan 2020 21:59:58 -0500 Received: by mail-pg1-f180.google.com with SMTP id b9so10902170pgk.12 for ; Thu, 16 Jan 2020 18:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=z+YdJeFqFDZRiS6UDwTkhXHC91WQ1PZ11Rxt5I2e+FU=; b=OME1BEPmzQ43q7L6b6RwcTDzN4ky8vN6iW5h0/2emyXIECsky7iZXPnqyzRv093ppZ lF0W5SFvL5CCJjGYa22yIVb+8y4vpQrqZiwGICPwjOcoZnkUVVipcELGMXwoXaEtdZIG dj3GcBd9bPOvsyLDUbzX98O1FdmUNP7uO1rDk3g4htEdgpkeHtlcWflNGj5DeYdJQPT4 X3ERHWTE/Y8Ppz3iq6d8lVBDzsbSmqqJeVuvtkHKQmXBi6dAfWO/ltPBZp6b5R0q+e9s gSj/VoDBc2HjcicB1V5XWrsIwhmg1pzxniaQDupXt3oVaFiygCDcyLLDUskLIYvOz2wJ uA/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z+YdJeFqFDZRiS6UDwTkhXHC91WQ1PZ11Rxt5I2e+FU=; b=m3BWvvs5Sd03vsIaMugOtGe4vQfKIyiUDWNOq4/0Xb9EwkssO8hni9bXDl61jd4cq7 NbzC8Fcc6hsa1AIAceSOASWTr1AKUrh/u9AISmqJ7y1yM0//bQmGxe5eyFKCqlPKeSSO X+Ugr7Bf6t+otRjkQLfRLljfIwn4wagTHg+hVAP03tKTxNIs7YFn0mdrJFdz5J70BHQz CxMHdTUyI0lmCeuSgUIbzctoLU7do613J2mipCgidihEsO58D6hrmpylR9opJkDJU8a/ sbSTh7V7asfzknBKEms44n54b4NQZu1L8ginjko91K9fuHIGxGnzBBY5w+x3vBTIWZ22 pWHw== X-Gm-Message-State: APjAAAUryBggW5emSmsrpiQWfYLjm6Y/BITviabGi8owHv283bYNFeqd jVfO+KCIP6aKpP1yQyAwyCtjiZXQ76t21g== X-Received: by 2002:a62:446:: with SMTP id 67mr713329pfe.109.1579229997428; Thu, 16 Jan 2020 18:59:57 -0800 (PST) Received: from ?IPv6:2600:380:4b14:d397:f0a3:4fc6:c904:323a? ([2600:380:4b14:d397:f0a3:4fc6:c904:323a]) by smtp.gmail.com with ESMTPSA id a26sm27407001pfo.27.2020.01.16.18.59.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2020 18:59:57 -0800 (PST) Subject: Re: [PATCH] io_uring: remove extra check in __io_commit_cqring To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <0d023acc096d63db454927590a5aca07deeac1cf.1579222330.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: Date: Thu, 16 Jan 2020 19:59:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <0d023acc096d63db454927590a5aca07deeac1cf.1579222330.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/16/20 5:52 PM, Pavel Begunkov wrote: > __io_commit_cqring() is almost always called when there is a change in > the rings, so the check is rather pessimising. Applied, thanks. -- Jens Axboe