Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200116194658.78893-1-manu@freebsd.org>
In-Reply-To: <20200116194658.78893-1-manu@freebsd.org>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Fri, 17 Jan 2020 11:20:21 +0800
Message-ID: <CAGb2v67U6qjNf0PPMOm191UZDQvJTGZNNREc22ZsDW61KqaUEA@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
To:     Emmanuel Vadot <manu@freebsd.org>
Cc:     Maxime Ripard <mripard@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 17, 2020 at 3:47 AM Emmanuel Vadot <manu@freebsd.org> wrote:
>
> Add the regulators for each bank on this boards.
>
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-olinuxino.dts   | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index 01a9a52edae4..1a25abf6065c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -163,6 +163,17 @@ &ohci1 {
>         status = "okay";
>  };
>
> +&pio {
> +       vcc-pa-supply = <&reg_dcdc1>;
> +       vcc-pb-supply = <&reg_dcdc1>;
> +       vcc-pc-supply = <&reg_dcdc1>;
> +       vcc-pd-supply = <&reg_dcdc1>;
> +       vcc-pe-supply = <&reg_aldo1>;
> +       vcc-pf-supply = <&reg_dcdc1>;
> +       vcc-pg-supply = <&reg_dldo4>;
> +       vcc-ph-supply = <&reg_dcdc1>;
> +};
> +
>  &r_rsb {
>         status = "okay";
>
> @@ -175,6 +186,10 @@ axp803: pmic@3a3 {
>         };
>  };
>
> +&r_pio {
> +       vcc-pl-supply = <&reg_aldo2>;

This is likely going to cause a circular dependency, because the RSB
interface that is used to talk to the PMIC is also on the PL pins.

(How does FreeBSD deal with this?)

Instead, just add a comment describing what is really used, and set
the regulator to always-on, which should already be the case.

ChenYu

> +};
> +
>  #include "axp803.dtsi"
>
>  &ac_power_supply {
> --
> 2.24.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel