Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] IMA: pre-allocate buffer to hold keyrings string
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
        linux-integrity@vger.kernel.org
Cc:     sashal@kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 16 Jan 2020 22:36:21 -0500
In-Reply-To: <20200117021821.2566-1-nramas@linux.microsoft.com>
References: <20200117021821.2566-1-nramas@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <1579232181.5125.3.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-01-16 at 18:18 -0800, Lakshmi Ramasubramanian wrote:
> ima_match_keyring() is called while holding rcu read lock. Since this
> function executes in atomic context, it should not call any function
> that can sleep (such as kstrdup()).
> 
> This patch pre-allocates a buffer to hold the keyrings string read from
> the IMA policy and uses that to match the given keyring.
> 
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> Fixes: e9085e0ad38a ("IMA: Add support to limit measuring keys")

Thanks!  This patch is now queued in next-integrity-testing.

Mimi