Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] usb: gadget: xudc: Remove redundant
 platform_get_irq error message
To:     YueHaibing <yuehaibing@huawei.com>, <balbi@kernel.org>,
        <gregkh@linuxfoundation.org>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <felipe.balbi@linux.intel.com>
CC:     <linux-usb@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200116141433.57056-1-yuehaibing@huawei.com>
From:   Nagarjuna Kristam <nkristam@nvidia.com>
Message-ID: <0a693269-3727-bb71-414e-856eab485353@nvidia.com>
Date:   Fri, 17 Jan 2020 09:36:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200116141433.57056-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Nagarjuna Kristam <nkristam@nvidia.com>

On 16-01-2020 19:44, YueHaibing wrote:
> External email: Use caution opening links or attachments
> 
> 
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index 634c2c1..fc1eafc 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
>          }
> 
>          xudc->irq = platform_get_irq(pdev, 0);
> -       if (xudc->irq < 0) {
> -               dev_err(xudc->dev, "failed to get IRQ: %d\n",
> -                               xudc->irq);
> +       if (xudc->irq < 0)
>                  return xudc->irq;
> -       }
> 
>          err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
>                                 dev_name(&pdev->dev), xudc);
> --
> 2.7.4
> 
>